From: roopa <roopa@cumulusnetworks.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: rshearma@brocade.com, davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next RFC] mpls: support for dead routes
Date: Mon, 02 Nov 2015 13:18:27 -0800 [thread overview]
Message-ID: <5637D323.7090602@cumulusnetworks.com> (raw)
In-Reply-To: <87d1vtt2di.fsf@x220.int.ebiederm.org>
On 11/1/15, 9:08 PM, Eric W. Biederman wrote:
> roopa <roopa@cumulusnetworks.com> writes:
>
>> On 11/1/15, 1:27 PM, Eric W. Biederman wrote:
>>> Roopa Prabhu <roopa@cumulusnetworks.com> writes:
>>>
>>>> diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
>>>> index c70d750..7db9678 100644
>>>> --- a/net/mpls/af_mpls.c
>>>> +++ b/net/mpls/af_mpls.c
>>>> @@ -27,6 +27,8 @@
>>>> */
>>>> #define MAX_MP_SELECT_LABELS 4
>>>>
>>>> +u32 mpls_multipath_secret __read_mostly;
>>> This mpls_multipath_secret is never used.
>>>
>> It is used in mpls_multipath_rebalance, same as fib_rebalance.
> fib_multipath_secret is only initialized in fib_rebalalance.
> fib_multipath_secret is used used in fib_multipath_hash,
> which is called in fib_select_path.
>
> The equivalent code does not exist in your mpls patch.
sorry, missed that. I have posted a new version.
next prev parent reply other threads:[~2015-11-02 21:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 15:49 [PATCH net-next RFC] mpls: support for dead routes Roopa Prabhu
2015-10-29 16:53 ` Robert Shearman
2015-10-29 18:46 ` roopa
2015-10-30 15:06 ` Robert Shearman
2015-11-01 21:24 ` Eric W. Biederman
2015-11-01 21:27 ` Eric W. Biederman
2015-11-02 1:01 ` roopa
2015-11-02 5:08 ` Eric W. Biederman
2015-11-02 21:18 ` roopa [this message]
2015-11-02 19:29 ` [PATCH net-next] mpls: Don't accept multipath configuration until the support is complete Eric W. Biederman
2015-11-02 19:49 ` Sergei Shtylyov
2015-11-03 6:09 ` Eric W. Biederman
2015-11-03 14:03 ` roopa
2015-11-03 15:14 ` Robert Shearman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5637D323.7090602@cumulusnetworks.com \
--to=roopa@cumulusnetworks.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=rshearma@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).