From: Randy Dunlap <rdunlap@infradead.org>
To: linux-wireless <linux-wireless@vger.kernel.org>,
Kalle Valo <kvalo@codeaurora.org>
Cc: Felix Fietkau <nbd@nbd.name>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [PATCH] net: wireless: mediatek: fix mt76 LEDS build error
Date: Thu, 6 Sep 2018 15:28:12 -0700 [thread overview]
Message-ID: <563c7f90-1d9f-440c-4670-8fbebc9f76b0@infradead.org> (raw)
From: Randy Dunlap <rdunlap@infradead.org>
All of the mt76 driver options use its mac80211.o component,
which uses led interfaces, so each of them should depend on
LEDS_CLASS.
Fixes this build error:
drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_led_init':
drivers/net/wireless/mediatek/mt76/mac80211.c:119: undefined reference to `devm_of_led_classdev_register'
Fixes: 17f1de56df05 ("mt76: add common code shared between multiple chipsets")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Felix Fietkau <nbd@nbd.name>
Cc: Kalle Valo <kvalo@codeaurora.org>
---
drivers/net/wireless/mediatek/mt76/Kconfig | 3 +++
1 file changed, 3 insertions(+)
--- linux-next-20180906.orig/drivers/net/wireless/mediatek/mt76/Kconfig
+++ linux-next-20180906/drivers/net/wireless/mediatek/mt76/Kconfig
@@ -18,6 +18,7 @@ config MT76x0U
tristate "MediaTek MT76x0U (USB) support"
select MT76_CORE
depends on MAC80211
+ depends on LEDS_CLASS
depends on USB
select MT76x02_LIB
help
@@ -28,6 +29,7 @@ config MT76x2E
select MT76_CORE
select MT76x2_COMMON
depends on MAC80211
+ depends on LEDS_CLASS
depends on PCI
---help---
This adds support for MT7612/MT7602/MT7662-based wireless PCIe devices.
@@ -38,6 +40,7 @@ config MT76x2U
select MT76_USB
select MT76x2_COMMON
depends on MAC80211
+ depends on LEDS_CLASS
depends on USB
help
This adds support for MT7612U-based wireless USB dongles.
reply other threads:[~2018-09-07 3:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563c7f90-1d9f-440c-4670-8fbebc9f76b0@infradead.org \
--to=rdunlap@infradead.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).