From: Daniel Borkmann <daniel@iogearbox.net>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, edumazet@google.com, willemb@google.com,
tklauser@distanz.ch, netdev@vger.kernel.org, jasowang@redhat.com
Subject: Re: [PATCH net 1/2] packet: do skb_probe_transport_header when we actually have data
Date: Mon, 09 Nov 2015 12:31:59 +0100 [thread overview]
Message-ID: <5640842F.3000109@iogearbox.net> (raw)
In-Reply-To: <20151107.172928.239564395518699740.davem@davemloft.net>
On 11/07/2015 11:29 PM, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Sat, 07 Nov 2015 10:53:50 -0800
>
>> Well, imagine following scenario (a real one, as I use it all of
>> time, thus how I discovered all trafgen traffic ends up on one slave
>> only)
>>
>> Even if qdisc is bypassed on the bond0, the current handling does
>> not prevent going to the slave qdiscs.
>
> Ok, depending upon the semantics Daniel intended, we may have to add
> a qdisc bypass boolean bit to SKBs.
It was resembling pktgen to some extend, only to be more flexible in
terms of defining packet payload (trafgen, I mean). Yes, pktgen has
the same issue on that regard, hmm I'm not yet sure, though, if it's
worth burning an extra skb bit for both cases.
next prev parent reply other threads:[~2015-11-09 11:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 21:02 [PATCH net 0/2] packet fix Daniel Borkmann
2015-11-06 21:02 ` [PATCH net 1/2] packet: do skb_probe_transport_header when we actually have data Daniel Borkmann
2015-11-07 12:42 ` Eric Dumazet
2015-11-07 18:35 ` David Miller
2015-11-07 18:53 ` Eric Dumazet
2015-11-07 19:06 ` Eric Dumazet
2015-11-08 0:33 ` Daniel Borkmann
2015-11-09 3:11 ` David Miller
2015-11-09 8:43 ` Daniel Borkmann
2015-11-07 22:29 ` David Miller
2015-11-09 11:31 ` Daniel Borkmann [this message]
2015-11-06 21:02 ` [PATCH net 2/2] packet: fix tpacket_snd max frame and vlan handling Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5640842F.3000109@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jasowang@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=tklauser@distanz.ch \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).