From: Ian McDonald <ian.mcdonald@jandi.co.uk>
To: Ivo Calado <ivocalado@embedded.ufcg.edu.br>
Cc: Gerrit Renker <gerrit@erg.abdn.ac.uk>,
dccp@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/5] First Patch on TFRC-SP. Copy base files from TFRC
Date: Tue, 15 Sep 2009 06:25:23 +0100 [thread overview]
Message-ID: <5640c8aa0909142225q73e477fcga99a48c218d10e0b@mail.gmail.com> (raw)
In-Reply-To: <cb00fa210909141738l60d02cd5p287d990326ce6c3c@mail.gmail.com>
2009/9/15 Ivo Calado <ivocalado@embedded.ufcg.edu.br>
>
> Hi Gerrit and all.
> Thank you for your fast reply. My comments follow below
>
> >
> > net/dccp/ccids/lib/tfrc_equation_sp.c
> > -------------------------------------
> > This is a prime candidate for removal. After editing out the whitespace
> > differences, I found that it is 100% identical with tfrc_equation.c.
> >
> > The result of this editing has been uploaded to
> > http://eden-feed.erg.abdn.ac.uk/tfrc_sp_receiver_01.patch
> >
> One future patch will need to modify this file, but now it's really an
> exact copy.
>
>
Basically the rule with a patch set is that all the patches should
make sense together.
It may well be that it makes sense to make a copy, but if you want to
do this then present it with the patch that then modifies it.
Ian
next prev parent reply other threads:[~2009-09-15 5:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-08 18:28 [PATCH 1/5] First Patch on TFRC-SP. Copy base files from TFRC Ivo Calado
2009-09-12 18:32 ` Gerrit Renker
2009-09-15 0:38 ` Ivo Calado
2009-09-15 5:25 ` Ian McDonald [this message]
2009-09-18 22:54 ` gerrit
2009-09-19 6:16 ` gerrit
2009-10-13 17:18 ` [PATCHv2 1/4] " Ivo Calado
2009-10-13 18:06 ` Jarek Poplawski
2009-10-13 18:12 ` Ivo Calado
2009-10-13 18:21 ` Jarek Poplawski
2009-10-13 18:25 ` Ivo Calado
2009-10-13 18:42 ` Arnaldo Carvalho de Melo
2009-10-13 18:53 ` Jarek Poplawski
2009-10-19 5:21 ` Gerrit Renker
2009-10-20 13:51 ` Ivo Calado
-- strict thread matches above, loose matches on Subject: below --
2009-09-04 12:24 [PATCH 1/5] " Ivo Calado
[not found] <cb00fa210909011735l5038c28eofba84b3976902964@mail.gmail.com>
2009-09-02 2:44 ` Ivo Calado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5640c8aa0909142225q73e477fcga99a48c218d10e0b@mail.gmail.com \
--to=ian.mcdonald@jandi.co.uk \
--cc=dccp@vger.kernel.org \
--cc=gerrit@erg.abdn.ac.uk \
--cc=ivocalado@embedded.ufcg.edu.br \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).