* [PATCH 2/6] net: dsa: mv88e6060: use the correct InitReady bit
@ 2015-11-10 13:25 Neil Armstrong
2015-11-10 14:16 ` Vivien Didelot
0 siblings, 1 reply; 2+ messages in thread
From: Neil Armstrong @ 2015-11-10 13:25 UTC (permalink / raw)
To: netdev
Cc: linux-kernel, David S. Miller, Florian Fainelli, Andrew Lunn,
Guenter Roeck, Neil Armstrong, Vivien Didelot
According to the mv88e6060 datasheet, the InitReady bit position
is 11 and the polarity is inverted.
Use the bit correctly to detect the end of initialization.
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
drivers/net/dsa/mv88e6060.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6060.c b/drivers/net/dsa/mv88e6060.c
index 6885ef5..26f668c 100644
--- a/drivers/net/dsa/mv88e6060.c
+++ b/drivers/net/dsa/mv88e6060.c
@@ -102,7 +102,7 @@ static int mv88e6060_switch_reset(struct dsa_switch *ds)
timeout = jiffies + 1 * HZ;
while (time_before(jiffies, timeout)) {
ret = REG_READ(REG_GLOBAL, 0x00);
- if ((ret & 0x8000) == 0x0000)
+ if ((ret & 0x800))
break;
usleep_range(1000, 2000);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 2/6] net: dsa: mv88e6060: use the correct InitReady bit
2015-11-10 13:25 [PATCH 2/6] net: dsa: mv88e6060: use the correct InitReady bit Neil Armstrong
@ 2015-11-10 14:16 ` Vivien Didelot
0 siblings, 0 replies; 2+ messages in thread
From: Vivien Didelot @ 2015-11-10 14:16 UTC (permalink / raw)
To: Neil Armstrong
Cc: netdev, linux-kernel, David S. Miller, Florian Fainelli,
Andrew Lunn, Guenter Roeck
On Nov. Tuesday 10 (46) 02:25 PM, Neil Armstrong wrote:
> According to the mv88e6060 datasheet, the InitReady bit position
> is 11 and the polarity is inverted.
> Use the bit correctly to detect the end of initialization.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> drivers/net/dsa/mv88e6060.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/mv88e6060.c b/drivers/net/dsa/mv88e6060.c
> index 6885ef5..26f668c 100644
> --- a/drivers/net/dsa/mv88e6060.c
> +++ b/drivers/net/dsa/mv88e6060.c
> @@ -102,7 +102,7 @@ static int mv88e6060_switch_reset(struct dsa_switch *ds)
> timeout = jiffies + 1 * HZ;
> while (time_before(jiffies, timeout)) {
> ret = REG_READ(REG_GLOBAL, 0x00);
> - if ((ret & 0x8000) == 0x0000)
> + if ((ret & 0x800))
> break;
You can drop a pair of parenthesis here.
>
> usleep_range(1000, 2000);
Thanks,
-v
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-10 14:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-10 13:25 [PATCH 2/6] net: dsa: mv88e6060: use the correct InitReady bit Neil Armstrong
2015-11-10 14:16 ` Vivien Didelot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).