* [PATCH net] be2net: check properly status in lancer_cmd_get_file_len()
@ 2015-11-13 9:52 Ivan Vecera
2015-11-16 8:57 ` Sathya Perla
0 siblings, 1 reply; 3+ messages in thread
From: Ivan Vecera @ 2015-11-13 9:52 UTC (permalink / raw)
To: netdev
Cc: sriharsha.basavapatna, sathya.perla, ajit.khaparde,
padmanabh.ratnakar
The lancer_cmd_get_file_len() calls lancer_cmd_read_object() to get
the current size of registers for ethtool registers dump. The size
is stored in data_read but only when the returned status is 0 otherwise
it is uninitialized thus random.
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
drivers/net/ethernet/emulex/benet/be_ethtool.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c b/drivers/net/ethernet/emulex/benet/be_ethtool.c
index f4cb8e4..26b6192 100644
--- a/drivers/net/ethernet/emulex/benet/be_ethtool.c
+++ b/drivers/net/ethernet/emulex/benet/be_ethtool.c
@@ -248,6 +248,8 @@ static u32 lancer_cmd_get_file_len(struct be_adapter *adapter, u8 *file_name)
status = lancer_cmd_read_object(adapter, &data_len_cmd, 0, 0,
file_name, &data_read, &eof,
&addn_status);
+ if (status)
+ return 0;
return data_read;
}
--
2.4.10
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] be2net: check properly status in lancer_cmd_get_file_len()
2015-11-13 9:52 [PATCH net] be2net: check properly status in lancer_cmd_get_file_len() Ivan Vecera
@ 2015-11-16 8:57 ` Sathya Perla
2015-11-16 9:21 ` Ivan Vecera
0 siblings, 1 reply; 3+ messages in thread
From: Sathya Perla @ 2015-11-16 8:57 UTC (permalink / raw)
To: Ivan Vecera
Cc: netdev, Sriharsha Basavapatna, Ajit Kumar Khaparde,
Padmanabh Ratnakar
On Fri, Nov 13, 2015 at 3:22 PM, Ivan Vecera <ivecera@redhat.com> wrote:
> The lancer_cmd_get_file_len() calls lancer_cmd_read_object() to get
> the current size of registers for ethtool registers dump. The size
> is stored in data_read but only when the returned status is 0 otherwise
> it is uninitialized thus random.
>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
> drivers/net/ethernet/emulex/benet/be_ethtool.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c b/drivers/net/ethernet/emulex/benet/be_ethtool.c
> index f4cb8e4..26b6192 100644
> --- a/drivers/net/ethernet/emulex/benet/be_ethtool.c
> +++ b/drivers/net/ethernet/emulex/benet/be_ethtool.c
> @@ -248,6 +248,8 @@ static u32 lancer_cmd_get_file_len(struct be_adapter *adapter, u8 *file_name)
> status = lancer_cmd_read_object(adapter, &data_len_cmd, 0, 0,
> file_name, &data_read, &eof,
> &addn_status);
> + if (status)
> + return 0;
>
> return data_read;
Ivan, unless I'm missing something...I see that "data_read" is
initialized to 0 in this routine. So, this routine will return 0 when
lancer_cmd_read_object() returns a non-zero status.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] be2net: check properly status in lancer_cmd_get_file_len()
2015-11-16 8:57 ` Sathya Perla
@ 2015-11-16 9:21 ` Ivan Vecera
0 siblings, 0 replies; 3+ messages in thread
From: Ivan Vecera @ 2015-11-16 9:21 UTC (permalink / raw)
To: Sathya Perla
Cc: netdev, Sriharsha Basavapatna, Ajit Kumar Khaparde,
Padmanabh Ratnakar
On 11/16/2015 09:57 AM, Sathya Perla wrote:
> On Fri, Nov 13, 2015 at 3:22 PM, Ivan Vecera <ivecera@redhat.com> wrote:
>> The lancer_cmd_get_file_len() calls lancer_cmd_read_object() to get
>> the current size of registers for ethtool registers dump. The size
>> is stored in data_read but only when the returned status is 0 otherwise
>> it is uninitialized thus random.
>>
>> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
>> ---
>> drivers/net/ethernet/emulex/benet/be_ethtool.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c b/drivers/net/ethernet/emulex/benet/be_ethtool.c
>> index f4cb8e4..26b6192 100644
>> --- a/drivers/net/ethernet/emulex/benet/be_ethtool.c
>> +++ b/drivers/net/ethernet/emulex/benet/be_ethtool.c
>> @@ -248,6 +248,8 @@ static u32 lancer_cmd_get_file_len(struct be_adapter *adapter, u8 *file_name)
>> status = lancer_cmd_read_object(adapter, &data_len_cmd, 0, 0,
>> file_name, &data_read, &eof,
>> &addn_status);
>> + if (status)
>> + return 0;
>>
>> return data_read;
>
> Ivan, unless I'm missing something...I see that "data_read" is
> initialized to 0 in this routine. So, this routine will return 0 when
> lancer_cmd_read_object() returns a non-zero status.
Yeah, you are right...my bad eyes. I was confused that status is read
but not checked... In this case 'status' var can be removed.
Ivan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-16 9:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-13 9:52 [PATCH net] be2net: check properly status in lancer_cmd_get_file_len() Ivan Vecera
2015-11-16 8:57 ` Sathya Perla
2015-11-16 9:21 ` Ivan Vecera
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).