[PATCH] ethernet/atheros/alx: add Killer E2400 device ID

[PATCH] ethernet/atheros/alx: add Killer E2400 device ID

[Jason Gerard DeRose]

From: Ben Pope <benpope81@gmail.com>

This patch adds the PCI device ID (0xe0a1) and alx_pci_tbl entry for the
Killer E2400 Ethernet controller, modeled after the Killer E2200
controller support (0xe091) already present in the alx driver.

This patch was originally authored by Ben Pope, but it got held up by
issues in the commit message, so I'm resubmitting it on his behalf.

I've extensively used a kernel with this patch on a System76 serw9
laptop and am quite confident it works well (at least on the hardware I
have available for testing).

Note that as a favor to System76, Ubuntu has been carrying this as a
sauce patch in their 4.2 based Wily kernel, which presumably has given
it real-world testing on other E2400 equipped hardware (I don't know of
any Ubuntu kernel bugs filed about it):

https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1498633

Signed-off-by: Jason Gerard DeRose <jason@system76.com>
---
 drivers/net/ethernet/atheros/alx/main.c | 2 ++
 drivers/net/ethernet/atheros/alx/reg.h  | 1 +
 2 files changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/atheros/alx/main.c b/drivers/net/ethernet/atheros/alx/main.c
index c8af3ce..bd377a6 100644
--- a/drivers/net/ethernet/atheros/alx/main.c
+++ b/drivers/net/ethernet/atheros/alx/main.c
@@ -1534,6 +1534,8 @@ static const struct pci_device_id alx_pci_tbl[] = {
 	  .driver_data = ALX_DEV_QUIRK_MSI_INTX_DISABLE_BUG },
 	{ PCI_VDEVICE(ATTANSIC, ALX_DEV_ID_E2200),
 	  .driver_data = ALX_DEV_QUIRK_MSI_INTX_DISABLE_BUG },
+	{ PCI_VDEVICE(ATTANSIC, ALX_DEV_ID_E2400),
+	  .driver_data = ALX_DEV_QUIRK_MSI_INTX_DISABLE_BUG },
 	{ PCI_VDEVICE(ATTANSIC, ALX_DEV_ID_AR8162),
 	  .driver_data = ALX_DEV_QUIRK_MSI_INTX_DISABLE_BUG },
 	{ PCI_VDEVICE(ATTANSIC, ALX_DEV_ID_AR8171) },
diff --git a/drivers/net/ethernet/atheros/alx/reg.h b/drivers/net/ethernet/atheros/alx/reg.h
index af006b4..0959e68 100644
--- a/drivers/net/ethernet/atheros/alx/reg.h
+++ b/drivers/net/ethernet/atheros/alx/reg.h
@@ -37,6 +37,7 @@
 
 #define ALX_DEV_ID_AR8161				0x1091
 #define ALX_DEV_ID_E2200				0xe091
+#define ALX_DEV_ID_E2400				0xe0a1
 #define ALX_DEV_ID_AR8162				0x1090
 #define ALX_DEV_ID_AR8171				0x10A1
 #define ALX_DEV_ID_AR8172				0x10A0
-- 
2.5.0

Re: [PATCH] ethernet/atheros/alx: add Killer E2400 device ID

[Sergei Shtylyov]

Hello.

On 11/18/2015 4:21 AM, Jason Gerard DeRose wrote:

> From: Ben Pope <benpope81@gmail.com>
>
> This patch adds the PCI device ID (0xe0a1) and alx_pci_tbl entry for the
> Killer E2400 Ethernet controller, modeled after the Killer E2200
> controller support (0xe091) already present in the alx driver.
>
> This patch was originally authored by Ben Pope, but it got held up by
> issues in the commit message, so I'm resubmitting it on his behalf.
>
> I've extensively used a kernel with this patch on a System76 serw9
> laptop and am quite confident it works well (at least on the hardware I
> have available for testing).
>
> Note that as a favor to System76, Ubuntu has been carrying this as a
> sauce patch in their 4.2 based Wily kernel, which presumably has given
> it real-world testing on other E2400 equipped hardware (I don't know of
> any Ubuntu kernel bugs filed about it):
>
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1498633
>
> Signed-off-by: Jason Gerard DeRose <jason@system76.com>

    No sign-off from Ben?

[...]

MBR, Sergei

Re: [PATCH] ethernet/atheros/alx: add Killer E2400 device ID

[Jason Gerard DeRose]

Sergei,

On 11/18/2015 07:01 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 11/18/2015 4:21 AM, Jason Gerard DeRose wrote:
>
>> From: Ben Pope <benpope81@gmail.com>
>>
>> This patch adds the PCI device ID (0xe0a1) and alx_pci_tbl entry for the
>> Killer E2400 Ethernet controller, modeled after the Killer E2200
>> controller support (0xe091) already present in the alx driver.
>>
>> This patch was originally authored by Ben Pope, but it got held up by
>> issues in the commit message, so I'm resubmitting it on his behalf.
>>
>> I've extensively used a kernel with this patch on a System76 serw9
>> laptop and am quite confident it works well (at least on the hardware I
>> have available for testing).
>>
>> Note that as a favor to System76, Ubuntu has been carrying this as a
>> sauce patch in their 4.2 based Wily kernel, which presumably has given
>> it real-world testing on other E2400 equipped hardware (I don't know of
>> any Ubuntu kernel bugs filed about it):
>>
>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1498633
>>
>> Signed-off-by: Jason Gerard DeRose <jason@system76.com>
>
>     No sign-off from Ben?

Apologies, this is my first time submitting a kernel patch :)

Should I use git send-email to send this again, this time with the 
sign-off from Ben? And if so, should I do so as a reply to this thread?

Thanks for you time!

> [...]
>
> MBR, Sergei
>

Re: [PATCH] ethernet/atheros/alx: add Killer E2400 device ID

[Sergei Shtylyov]

On 11/18/2015 05:52 PM, Jason Gerard DeRose wrote:

>>> From: Ben Pope <benpope81@gmail.com>
>>>
>>> This patch adds the PCI device ID (0xe0a1) and alx_pci_tbl entry for the
>>> Killer E2400 Ethernet controller, modeled after the Killer E2200
>>> controller support (0xe091) already present in the alx driver.
>>>
>>> This patch was originally authored by Ben Pope, but it got held up by
>>> issues in the commit message, so I'm resubmitting it on his behalf.
>>>
>>> I've extensively used a kernel with this patch on a System76 serw9
>>> laptop and am quite confident it works well (at least on the hardware I
>>> have available for testing).
>>>
>>> Note that as a favor to System76, Ubuntu has been carrying this as a
>>> sauce patch in their 4.2 based Wily kernel, which presumably has given
>>> it real-world testing on other E2400 equipped hardware (I don't know of
>>> any Ubuntu kernel bugs filed about it):
>>>
>>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1498633
>>>
>>> Signed-off-by: Jason Gerard DeRose <jason@system76.com>
>>
>>     No sign-off from Ben?
>
> Apologies, this is my first time submitting a kernel patch :)
>
> Should I use git send-email to send this again,

    I didn't notice if your mailer corrupted the patch but if it did 'git 
send-email' should be used indeed.

> this time with the sign-off from Ben?

    No need to resend if it wasn't corrupted. Just replying to this patch with 
his sign-off should be enough -- patchwork should collect the tags from the 
follow-ups.

> And if so, should I do so as a reply to this thread?

    No, not on this list. DaveM prefers the patch reposts to be done as the 
fresh new postings.

> Thanks for you time!

    Your, I guess? Not at all. :-)

MBR, Sergei

Re: [PATCH] ethernet/atheros/alx: add Killer E2400 device ID

[Jason Gerard DeRose]

On 11/18/2015 10:47 AM, Sergei Shtylyov wrote:
> On 11/18/2015 05:52 PM, Jason Gerard DeRose wrote:
>
>>>> From: Ben Pope <benpope81@gmail.com>
>>>>
>>>> This patch adds the PCI device ID (0xe0a1) and alx_pci_tbl entry for
>>>> the
>>>> Killer E2400 Ethernet controller, modeled after the Killer E2200
>>>> controller support (0xe091) already present in the alx driver.
>>>>
>>>> This patch was originally authored by Ben Pope, but it got held up by
>>>> issues in the commit message, so I'm resubmitting it on his behalf.
>>>>
>>>> I've extensively used a kernel with this patch on a System76 serw9
>>>> laptop and am quite confident it works well (at least on the hardware I
>>>> have available for testing).
>>>>
>>>> Note that as a favor to System76, Ubuntu has been carrying this as a
>>>> sauce patch in their 4.2 based Wily kernel, which presumably has given
>>>> it real-world testing on other E2400 equipped hardware (I don't know of
>>>> any Ubuntu kernel bugs filed about it):
>>>>
>>>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1498633
>>>>
>>>> Signed-off-by: Jason Gerard DeRose <jason@system76.com>
>>>
>>>     No sign-off from Ben?
>>
>> Apologies, this is my first time submitting a kernel patch :)
>>
>> Should I use git send-email to send this again,
>
>     I didn't notice if your mailer corrupted the patch but if it did
> 'git send-email' should be used indeed.

I originally used `git send-email`, so the patch should not have been 
corrupted.

>> this time with the sign-off from Ben?
>
>     No need to resend if it wasn't corrupted. Just replying to this
> patch with his sign-off should be enough -- patchwork should collect the
> tags from the follow-ups.

Okay, thanks for the clarification!

>> And if so, should I do so as a reply to this thread?
>
>     No, not on this list. DaveM prefers the patch reposts to be done as
> the fresh new postings.
>
>> Thanks for you time!
>
>     Your, I guess? Not at all. :-)

Also thank you for enduring my typos ;)

> MBR, Sergei
>

Re: [PATCH] ethernet/atheros/alx: add Killer E2400 device ID

[Ben Pope]

18/11/15 09:21, Jason Gerard DeRose wrote:
> From: Ben Pope <benpope81@gmail.com>
>
> This patch adds the PCI device ID (0xe0a1) and alx_pci_tbl entry for the
> Killer E2400 Ethernet controller, modeled after the Killer E2200
> controller support (0xe091) already present in the alx driver.
>
> This patch was originally authored by Ben Pope, but it got held up by
> issues in the commit message, so I'm resubmitting it on his behalf.
>
> I've extensively used a kernel with this patch on a System76 serw9
> laptop and am quite confident it works well (at least on the hardware I
> have available for testing).
>
> Note that as a favor to System76, Ubuntu has been carrying this as a
> sauce patch in their 4.2 based Wily kernel, which presumably has given
> it real-world testing on other E2400 equipped hardware (I don't know of
> any Ubuntu kernel bugs filed about it):
>
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1498633
>
> Signed-off-by: Jason Gerard DeRose <jason@system76.com>
> ---
>   drivers/net/ethernet/atheros/alx/main.c | 2 ++
>   drivers/net/ethernet/atheros/alx/reg.h  | 1 +
>   2 files changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/atheros/alx/main.c b/drivers/net/ethernet/atheros/alx/main.c
> index c8af3ce..bd377a6 100644
> --- a/drivers/net/ethernet/atheros/alx/main.c
> +++ b/drivers/net/ethernet/atheros/alx/main.c
> @@ -1534,6 +1534,8 @@ static const struct pci_device_id alx_pci_tbl[] = {
>   	  .driver_data = ALX_DEV_QUIRK_MSI_INTX_DISABLE_BUG },
>   	{ PCI_VDEVICE(ATTANSIC, ALX_DEV_ID_E2200),
>   	  .driver_data = ALX_DEV_QUIRK_MSI_INTX_DISABLE_BUG },
> +	{ PCI_VDEVICE(ATTANSIC, ALX_DEV_ID_E2400),
> +	  .driver_data = ALX_DEV_QUIRK_MSI_INTX_DISABLE_BUG },
>   	{ PCI_VDEVICE(ATTANSIC, ALX_DEV_ID_AR8162),
>   	  .driver_data = ALX_DEV_QUIRK_MSI_INTX_DISABLE_BUG },
>   	{ PCI_VDEVICE(ATTANSIC, ALX_DEV_ID_AR8171) },
> diff --git a/drivers/net/ethernet/atheros/alx/reg.h b/drivers/net/ethernet/atheros/alx/reg.h
> index af006b4..0959e68 100644
> --- a/drivers/net/ethernet/atheros/alx/reg.h
> +++ b/drivers/net/ethernet/atheros/alx/reg.h
> @@ -37,6 +37,7 @@
>   
>   #define ALX_DEV_ID_AR8161				0x1091
>   #define ALX_DEV_ID_E2200				0xe091
> +#define ALX_DEV_ID_E2400				0xe0a1
>   #define ALX_DEV_ID_AR8162				0x1090
>   #define ALX_DEV_ID_AR8171				0x10A1
>   #define ALX_DEV_ID_AR8172				0x10A0

Signed-off-by: Ben Pope <benpope81@gmail.com>

Re: [PATCH] ethernet/atheros/alx: add Killer E2400 device ID

[David Miller]

From: Jason Gerard DeRose <jason@system76.com>
Date: Tue, 17 Nov 2015 18:21:07 -0700

> From: Ben Pope <benpope81@gmail.com>
> 
> This patch adds the PCI device ID (0xe0a1) and alx_pci_tbl entry for the
> Killer E2400 Ethernet controller, modeled after the Killer E2200
> controller support (0xe091) already present in the alx driver.
> 
> This patch was originally authored by Ben Pope, but it got held up by
> issues in the commit message, so I'm resubmitting it on his behalf.
> 
> I've extensively used a kernel with this patch on a System76 serw9
> laptop and am quite confident it works well (at least on the hardware I
> have available for testing).
> 
> Note that as a favor to System76, Ubuntu has been carrying this as a
> sauce patch in their 4.2 based Wily kernel, which presumably has given
> it real-world testing on other E2400 equipped hardware (I don't know of
> any Ubuntu kernel bugs filed about it):
> 
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1498633
> 
> Signed-off-by: Jason Gerard DeRose <jason@system76.com>

Applied.

Re: [PATCH] ethernet/atheros/alx: add Killer E2400 device ID

[Jason Gerard DeRose]

On 11/18/2015 01:06 PM, David Miller wrote:
> From: Jason Gerard DeRose <jason@system76.com>
> Date: Tue, 17 Nov 2015 18:21:07 -0700
>
>> From: Ben Pope <benpope81@gmail.com>
>>
>> This patch adds the PCI device ID (0xe0a1) and alx_pci_tbl entry for the
>> Killer E2400 Ethernet controller, modeled after the Killer E2200
>> controller support (0xe091) already present in the alx driver.
>>
>> This patch was originally authored by Ben Pope, but it got held up by
>> issues in the commit message, so I'm resubmitting it on his behalf.
>>
>> I've extensively used a kernel with this patch on a System76 serw9
>> laptop and am quite confident it works well (at least on the hardware I
>> have available for testing).
>>
>> Note that as a favor to System76, Ubuntu has been carrying this as a
>> sauce patch in their 4.2 based Wily kernel, which presumably has given
>> it real-world testing on other E2400 equipped hardware (I don't know of
>> any Ubuntu kernel bugs filed about it):
>>
>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1498633
>>
>> Signed-off-by: Jason Gerard DeRose <jason@system76.com>
>
> Applied.

Much thanks!