From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Jason Gerard DeRose <jason@system76.com>, netdev@vger.kernel.org
Cc: Ben Pope <benpope81@gmail.com>
Subject: Re: [PATCH] ethernet/atheros/alx: add Killer E2400 device ID
Date: Wed, 18 Nov 2015 20:47:48 +0300 [thread overview]
Message-ID: <564CB9C4.3030100@cogentembedded.com> (raw)
In-Reply-To: <564C90BB.2040104@system76.com>
On 11/18/2015 05:52 PM, Jason Gerard DeRose wrote:
>>> From: Ben Pope <benpope81@gmail.com>
>>>
>>> This patch adds the PCI device ID (0xe0a1) and alx_pci_tbl entry for the
>>> Killer E2400 Ethernet controller, modeled after the Killer E2200
>>> controller support (0xe091) already present in the alx driver.
>>>
>>> This patch was originally authored by Ben Pope, but it got held up by
>>> issues in the commit message, so I'm resubmitting it on his behalf.
>>>
>>> I've extensively used a kernel with this patch on a System76 serw9
>>> laptop and am quite confident it works well (at least on the hardware I
>>> have available for testing).
>>>
>>> Note that as a favor to System76, Ubuntu has been carrying this as a
>>> sauce patch in their 4.2 based Wily kernel, which presumably has given
>>> it real-world testing on other E2400 equipped hardware (I don't know of
>>> any Ubuntu kernel bugs filed about it):
>>>
>>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1498633
>>>
>>> Signed-off-by: Jason Gerard DeRose <jason@system76.com>
>>
>> No sign-off from Ben?
>
> Apologies, this is my first time submitting a kernel patch :)
>
> Should I use git send-email to send this again,
I didn't notice if your mailer corrupted the patch but if it did 'git
send-email' should be used indeed.
> this time with the sign-off from Ben?
No need to resend if it wasn't corrupted. Just replying to this patch with
his sign-off should be enough -- patchwork should collect the tags from the
follow-ups.
> And if so, should I do so as a reply to this thread?
No, not on this list. DaveM prefers the patch reposts to be done as the
fresh new postings.
> Thanks for you time!
Your, I guess? Not at all. :-)
MBR, Sergei
next prev parent reply other threads:[~2015-11-18 17:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 1:21 [PATCH] ethernet/atheros/alx: add Killer E2400 device ID Jason Gerard DeRose
2015-11-18 14:01 ` Sergei Shtylyov
2015-11-18 14:52 ` Jason Gerard DeRose
2015-11-18 17:47 ` Sergei Shtylyov [this message]
2015-11-18 18:15 ` Jason Gerard DeRose
2015-11-18 14:28 ` Ben Pope
2015-11-18 20:06 ` David Miller
2015-11-18 21:48 ` Jason Gerard DeRose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564CB9C4.3030100@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=benpope81@gmail.com \
--cc=jason@system76.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).