From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: Cong Wang <cwang@twopensource.com>,
Nikolay Aleksandrov <razor@blackwall.org>
Cc: netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net-next v2 8/9] net: ipmr: rearrange and cleanup setsockopt
Date: Mon, 23 Nov 2015 11:49:02 +0100 [thread overview]
Message-ID: <5652EF1E.6090108@cumulusnetworks.com> (raw)
In-Reply-To: <CAHA+R7MO7OSjSTei7pSCZWmJzXNQqS8vPc0Z2fEz_m2vKvkd+Q@mail.gmail.com>
On 11/23/2015 06:44 AM, Cong Wang wrote:
> On Sat, Nov 21, 2015 at 6:57 AM, Nikolay Aleksandrov
> <razor@blackwall.org> wrote:
>> net/ipv4/ipmr.c | 191 +++++++++++++++++++++++++++++++-------------------------
>> 1 file changed, 107 insertions(+), 84 deletions(-)
>
> Does this really simplify the code? :-/
>
Did I really say it does ? :-) Now, to the point it just makes it
much easier to reason about this setsockopt which was doing conditional
locking in some of the cases before, and some were left out, also "v"
was sometimes signed and sometimes unsigned, it's clearer now which type
is used. I've left a comment why the only special case needs to unlock
rtnl (MRT_DONE).
next prev parent reply other threads:[~2015-11-23 10:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 14:57 [PATCH net-next v2 0/9] net: ipmr: cleanups and minor improvements Nikolay Aleksandrov
2015-11-21 14:57 ` [PATCH net-next v2 1/9] net: ipmr: move the tbl id check in ipmr_new_table Nikolay Aleksandrov
2015-11-21 14:57 ` [PATCH net-next v2 2/9] net: ipmr: always define mroute_reg_vif_num Nikolay Aleksandrov
2015-11-23 5:23 ` Cong Wang
2015-11-23 10:39 ` Nikolay Aleksandrov
2015-11-21 14:57 ` [PATCH net-next v2 3/9] net: ipmr: remove some pimsm ifdefs and simplify Nikolay Aleksandrov
2015-11-21 14:57 ` [PATCH net-next v2 4/9] net: ipmr: fix code and comment style Nikolay Aleksandrov
2015-11-23 5:30 ` Cong Wang
2015-11-23 10:40 ` Nikolay Aleksandrov
2015-11-21 14:57 ` [PATCH net-next v2 5/9] net: ipmr: make ip_mroute_getsockopt more understandable Nikolay Aleksandrov
2015-11-21 14:57 ` [PATCH net-next v2 6/9] net: ipmr: drop an instance of CONFIG_IP_MROUTE_MULTIPLE_TABLES Nikolay Aleksandrov
2015-11-21 14:57 ` [PATCH net-next v2 7/9] net: ipmr: drop ip_mr_init() mrt_cachep null check as we'll panic if it fails Nikolay Aleksandrov
2015-11-21 14:57 ` [PATCH net-next v2 8/9] net: ipmr: rearrange and cleanup setsockopt Nikolay Aleksandrov
2015-11-23 5:44 ` Cong Wang
2015-11-23 10:49 ` Nikolay Aleksandrov [this message]
2015-11-21 14:57 ` [PATCH net-next v2 9/9] net: ipmr: factor out common vif init code Nikolay Aleksandrov
2015-11-23 20:07 ` [PATCH net-next v2 0/9] net: ipmr: cleanups and minor improvements David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5652EF1E.6090108@cumulusnetworks.com \
--to=nikolay@cumulusnetworks.com \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).