From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Wagner Subject: Re: [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in xt_cgroup Date: Mon, 23 Nov 2015 16:57:17 +0100 Message-ID: <5653375D.7000504@bmw-carit.de> References: <1448122441-9335-1-git-send-email-tj@kernel.org> <5652BC3A.1010701@bmw-carit.de> <5652D448.3080002@bmw-carit.de> <20151123155346.GE3049@mtj.duckdns.org> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Cc: , , , , , , , , , , , , , , To: Tejun Heo Return-path: In-Reply-To: <20151123155346.GE3049-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On 11/23/2015 04:53 PM, Tejun Heo wrote: > On Mon, Nov 23, 2015 at 09:54:32AM +0100, Daniel Wagner wrote: > ... >>> [ 3.224665] BUG: spinlock bad magic on CPU#1, systemd/1 >>> [ 3.225653] lock: cgroup_sk_update_lock+0x0/0x60, .magic: 00000000, .owner: systemd/1, .owner_cpu: 1 >>> [ 3.227034] CPU: 1 PID: 1 Comm: systemd Not tainted 4.4.0-rc1+ #195 >>> [ 3.227862] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.8.2-0-g33fbe13 by qemu-project.org 04/01/2014 >>> [ 3.228906] ffffffff834a2160 ffff88007c043ad0 ffffffff81551edc ffff88007c028000 >>> [ 3.229512] ffff88007c043af0 ffffffff81136868 ffffffff834a2160 ffff88007aff5940 >>> [ 3.230105] ffff88007c043b08 ffffffff81136b05 ffffffff834a2160 ffff88007c043b20 >>> [ 3.230716] Call Trace: >>> [ 3.230906] [] dump_stack+0x4e/0x82 >>> [ 3.231289] [] spin_dump+0x78/0xc0 >>> [ 3.231642] [] do_raw_spin_unlock+0x75/0xd0 >>> [ 3.232039] [] _raw_spin_unlock+0x27/0x50 >>> [ 3.232431] [] update_classid_sock+0x68/0x80 >>> [ 3.232836] [] iterate_fd+0x71/0x150 >>> [ 3.233197] [] update_classid+0x47/0x80 >>> [ 3.233571] [] cgrp_attach+0x14/0x20 >>> [ 3.233929] [] cgroup_taskset_migrate+0x1e1/0x330 >>> [ 3.234366] [] cgroup_migrate+0xf5/0x190 >>> [ 3.235130] [] cgroup_attach_task+0x176/0x200 >>> [ 3.235953] [] __cgroup_procs_write+0x2ad/0x460 >>> [ 3.236805] [] cgroup_procs_write+0x14/0x20 >>> [ 3.237205] [] cgroup_file_write+0x35/0x1c0 >>> [ 3.237600] [] kernfs_fop_write+0x141/0x190 >>> [ 3.237998] [] __vfs_write+0x28/0xe0 >>> [ 3.239554] [] vfs_write+0xac/0x1a0 >>> [ 3.240308] [] SyS_write+0x49/0xb0 >>> [ 3.240656] [] entry_SYSCALL_64_fastpath+0x12/0x76 >> >> I have enabled a few additional cgroup controllers as well, because I was >> trying to figure out why I only see the 'memory' cgroup controller in >> cgroup.controllers. pid and io show up but not net_prio or net_cls. >> Not sure why systemd (v227) is not mounting them. > > net_prio and net_cls aren't gonna be on the v2 hierarchy. The match > in this patchset is being introduced to replace them; however, you can > mount them separately on a v1 hierarchy and use the same as before. Okay, I could have figured that myself I guess. I mounted the v1 hierarchy and it works as you have described it.