From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Weinberger Subject: Re: bridge-utils: wrong sysfs path odds Date: Wed, 25 Nov 2015 10:21:15 +0100 Message-ID: <56557D8B.8090908@nod.at> References: <5654FD93.1070706@nod.at> <5654FFCF.2080801@nod.at> <20151124163735.6f9ad756@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" , Ralf Baechle , manty@debian.org To: Stephen Hemminger Return-path: Received: from a.ns.miles-group.at ([95.130.255.143]:11949 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750832AbbKYJVU (ORCPT ); Wed, 25 Nov 2015 04:21:20 -0500 In-Reply-To: <20151124163735.6f9ad756@xeon-e3> Sender: netdev-owner@vger.kernel.org List-ID: Am 25.11.2015 um 01:37 schrieb Stephen Hemminger: > On Wed, 25 Nov 2015 01:24:47 +0100 > Richard Weinberger wrote: > >> Am 25.11.2015 um 01:15 schrieb Richard Weinberger: >>> Hi! >>> >>> Today I was hunting down an issue where "brctl stp br0 off" >>> always failed on mips64be with n32 userland. >>> >>> It turned out that the ioctl(fd, SIOCDEVPRIVATE, &ifr) with BRCTL_SET_BRIDGE_STP_STATE >>> returned -EOPNOTSUPP. >>> First I thought that this is a plain ABI issue on mips as in old_dev_ioctl() >>> the ioctl() argument was 0x1 instead of the expected BRCTL_SET_BRIDGE_STP_STATE (0x14) >> >> Should be 0xe and not 0x14. It is 14 in decimal. :) >> >> Thanks, >> //richard > > Ask Debian maintainer to send his patches, I don't go patch hunting. > While looking what other distros do I came across this patch: https://pkgs.fedoraproject.org/cgit/bridge-utils.git/tree/bridge-utils-1.5-check-error-returns-from-write-to-sysfs.patch Beside of checking return errors is fixes also the sysfs path in br_set(). Can you please merge it upstream? Distros seems to carry more patches for that package, if it helps I can do the patch hunting for you. It would be nice to have a recent bridge-utils release. The last one is from 2011. Thanks, //richard