From: Haggai Eran <haggaie@mellanox.com>
To: Joe Stringer <joestringer@nicira.com>, Or Gerlitz <gerlitz.or@gmail.com>
Cc: Jesse Gross <jesse@kernel.org>,
Or Gerlitz <ogerlitz@mellanox.com>,
"Jesse Gross" <jesse@nicira.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Ilya Lesokhin <ilyal@mellanox.com>,
Rony Efraim <ronye@mellanox.com>,
"Hadar Hen Zion" <hadarh@mellanox.com>,
Jesse Gross <jesse@nicira.com>,
"Pravin B Shelar" <pshelar@nicira.com>
Subject: Re: OVS VXLAN decap rule has full match on TTL for the outer headers?
Date: Sun, 29 Nov 2015 15:06:17 +0200 [thread overview]
Message-ID: <565AF849.8030008@mellanox.com> (raw)
In-Reply-To: <CANr6G5xe7URQgr=C7gL=xoAaUf5rXPQByBZscmNSVHyv2=+wRg@mail.gmail.com>
On 14/11/2015 08:45, Joe Stringer wrote:
> On 13 November 2015 at 06:46, Or Gerlitz <gerlitz.or@gmail.com> wrote:
>> > On Fri, Nov 13, 2015 at 10:14 AM, Joe Stringer <joestringer@nicira.com> wrote:
>> >
>>> >> I don't follow the logic. You observed one flow which matched on
>>> >> TTL=64, therefore all vxlan packets terminated at OVS have TTL=64?
>> >
>>> >> If OVS received packets with different TTLs, they would miss and
>>> >> ovs-vswitchd would generate flows to match that traffic too.
>> >
>> > ok, that makes things a bit better, but (see next)
>> >
>>> >> If that becomes an issue, presumably the wildcard generation can be improved.
>> >
>> > is there a deep reason for vlxan "learned flows" to actually match w
>> > or w.o wild cards on TTLs?? for non-tunneled flow I don't see this
>> > happening.
> No deep reason I'm aware of.
Hi,
We looked into the OVS kernel module, and apparently there's a check
that rejects new tunnel flows if they don't have the TTL mask set [1].
I was able to trace it to this commit [2] on the OVS tree, but I don't
quite understand why the check was added. There was some discussion
about the patch on the mailing list [3] that hints this was about
catching zero TTL, but it has too little context for me to understand.
I'm adding the author and reviewer of the patch, perhaps they can help
explain this requirement.
Regards,
Haggai
[1]
http://lxr.free-electrons.com/source/net/openvswitch/flow_netlink.c?v=4.3#L660
[2] datapath: More flexible kernel/userspace tunneling attribute.
9b405f1aa8d175dc63ad3ffe5d0fe05d5ee09162
[3] http://openvswitch.org/pipermail/dev/2013-January/024573.html
next prev parent reply other threads:[~2015-11-29 13:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 14:47 OVS VXLAN decap rule has full match on TTL for the outer headers? Or Gerlitz
2015-11-11 22:44 ` Jesse Gross
2015-11-12 6:34 ` Or Gerlitz
2015-11-13 8:14 ` Joe Stringer
2015-11-13 14:46 ` Or Gerlitz
2015-11-14 6:45 ` Joe Stringer
2015-11-19 15:40 ` Or Gerlitz
2015-11-29 13:37 ` Or Gerlitz
2015-12-02 18:01 ` Joe Stringer
2015-12-08 19:20 ` Joe Stringer
2015-12-08 21:23 ` Or Gerlitz
2015-12-09 0:22 ` Joe Stringer
2015-12-10 21:06 ` Or Gerlitz
2015-12-10 21:23 ` Joe Stringer
2015-12-10 21:43 ` Or Gerlitz
2015-12-10 23:53 ` Joe Stringer
2015-11-29 13:06 ` Haggai Eran [this message]
2015-12-02 17:52 ` Joe Stringer
2015-12-02 18:04 ` Jesse Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565AF849.8030008@mellanox.com \
--to=haggaie@mellanox.com \
--cc=gerlitz.or@gmail.com \
--cc=hadarh@mellanox.com \
--cc=ilyal@mellanox.com \
--cc=jesse@kernel.org \
--cc=jesse@nicira.com \
--cc=joestringer@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=pshelar@nicira.com \
--cc=ronye@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).