From: Luuk Paulussen <Luuk.Paulussen@alliedtelesis.co.nz>
To: David Miller <davem@davemloft.net>,
"lorenzo@google.com" <lorenzo@google.com>
Cc: Matt Bennett <Matt.Bennett@alliedtelesis.co.nz>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: Increasing skb->mark size
Date: Mon, 30 Nov 2015 04:10:43 +0000 [thread overview]
Message-ID: <565BCC42.7020701@alliedtelesis.co.nz> (raw)
In-Reply-To: <20151129.205854.160622377475841200.davem@davemloft.net>
On 11/30/2015 02:58 PM, David Miller wrote:
> If you guys, really anyone, can find a way to remove some other 32-bit
> item from sk_buff, you can expand skb->mark to 64-bits. But otherwise,
> I'm going to be strongly against it. sk_buff is already enormous and
> larger than it should be. So I'm going to resist any change that makes
> it even larger. Thanks.
Would the level of objection be the same if this was done as an
"extended mark" field under a configurable off-by-default option? This
would allow users who need this functionality to enable it while making
it clear that this is at the expense of increasing sk_buff size.
next prev parent reply other threads:[~2015-11-30 4:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 20:32 Increasing skb->mark size Matt Bennett
2015-11-24 20:36 ` Florian Westphal
2015-11-24 20:56 ` Matt Bennett
2015-11-26 4:44 ` Luuk Paulussen
2015-11-30 2:08 ` Florian Westphal
2015-11-30 2:10 ` Lorenzo Colitti
2015-11-30 2:24 ` Florian Westphal
2015-11-29 8:37 ` Lorenzo Colitti
2015-11-30 1:58 ` David Miller
2015-11-30 4:10 ` Luuk Paulussen [this message]
2015-11-30 4:49 ` David Miller
2015-12-01 0:12 ` Luuk Paulussen
2015-12-01 3:55 ` David Miller
2015-12-01 4:57 ` Luuk Paulussen
2015-12-01 19:13 ` Andi Kleen
2015-12-01 22:09 ` Daniel Borkmann
2015-12-02 2:58 ` Andi Kleen
2015-12-02 5:42 ` David Ahern
2015-12-02 17:29 ` David Miller
2015-12-02 3:57 ` Lorenzo Colitti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565BCC42.7020701@alliedtelesis.co.nz \
--to=luuk.paulussen@alliedtelesis.co.nz \
--cc=Matt.Bennett@alliedtelesis.co.nz \
--cc=davem@davemloft.net \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).