netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: "Eric W. Biederman" <ebiederm@xmission.com>,
	David Miller <davem@davemloft.net>
Cc: Kees Cook <keescook@chromium.org>,
	"kernel-hardening@lists.openwall.com"
	<kernel-hardening@lists.openwall.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	bridge@lists.linux-foundation.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace
Date: Mon, 30 Nov 2015 23:57:29 +0100	[thread overview]
Message-ID: <565CD459.6010402@nod.at> (raw)
In-Reply-To: <87egf7183c.fsf_-_@x220.int.ebiederm.org>

Am 30.11.2015 um 22:38 schrieb Eric W. Biederman:
> 
> There is no defined mechanism to pass network namespace information
> into /sbin/bridge-stp therefore don't even try to invoke it except
> for bridge devices in the initial network namespace.
> 
> It is possible for unprivileged users to cause /sbin/bridge-stp to be
> invoked for any network device name which if /sbin/bridge-stp does not
> guard against unreasonable arguments or being invoked twice on the same
> network device could cause problems.
> 
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>

Just figured that /sbin/bridge-stp is a shell script.
Network interfaces can contain a lot of funny characters,
maybe this is after all a security issue.

Thanks,
//richard

  parent reply	other threads:[~2015-11-30 22:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-29 22:43 user controllable usermodehelper in br_stp_if.c Richard Weinberger
2015-11-30 20:14 ` Kees Cook
2015-11-30 21:38   ` [PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace Eric W. Biederman
2015-11-30 22:12     ` Stephen Hemminger
2015-11-30 22:16       ` Eric W. Biederman
2015-11-30 22:57     ` Richard Weinberger [this message]
2015-12-01 14:13     ` Hannes Frederic Sowa
2015-12-03  4:50     ` David Miller
2015-12-08 20:56       ` Kees Cook
2015-11-30 23:03   ` user controllable usermodehelper in br_stp_if.c Richard Weinberger
  -- strict thread matches above, loose matches on Subject: below --
2016-01-05  9:46 [PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace Hannes Frederic Sowa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565CD459.6010402@nod.at \
    --to=richard@nod.at \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).