* [PATCH 1/6] net: thunderx: Force to load octeon-mdio before bgx driver.
@ 2015-12-01 9:13 Sunil Goutham
2015-12-01 13:17 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Sunil Goutham @ 2015-12-01 9:13 UTC (permalink / raw)
To: netdev
Cc: linux-kernel, linux-arm-kernel, Sunil.Goutham,
Thanneeru Srinivasulu, Sunil Goutham
From: Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>
Signed-off-by: Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>
Signed-off-by: Sunil Goutham <sgoutham@cavium.com>
---
drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 3 +++
drivers/net/ethernet/cavium/thunder/thunder_bgx.h | 1 +
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
index 180aa9f..1fb72dd 100644
--- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
+++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
@@ -1009,6 +1009,9 @@ static int bgx_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
struct bgx *bgx = NULL;
u8 lmac;
+ /*Load octeon mdio driver*/
+ octeon_mdiobus_force_mod_depencency();
+
bgx = devm_kzalloc(dev, sizeof(*bgx), GFP_KERNEL);
if (!bgx)
return -ENOMEM;
diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.h b/drivers/net/ethernet/cavium/thunder/thunder_bgx.h
index 07b7ec6..89a02fa 100644
--- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.h
+++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.h
@@ -182,6 +182,7 @@ enum MCAST_MODE {
#define BCAST_ACCEPT 1
#define CAM_ACCEPT 1
+void octeon_mdiobus_force_mod_depencency(void);
void bgx_add_dmac_addr(u64 dmac, int node, int bgx_idx, int lmac);
unsigned bgx_get_map(int node);
int bgx_get_lmac_count(int node, int bgx);
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/6] net: thunderx: Force to load octeon-mdio before bgx driver.
2015-12-01 9:13 [PATCH 1/6] net: thunderx: Force to load octeon-mdio before bgx driver Sunil Goutham
@ 2015-12-01 13:17 ` Sergei Shtylyov
2015-12-01 16:24 ` Sunil Kovvuri
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2015-12-01 13:17 UTC (permalink / raw)
To: Sunil Goutham, netdev
Cc: linux-kernel, linux-arm-kernel, Sunil.Goutham,
Thanneeru Srinivasulu, Sunil Goutham
Hello.
On 12/1/2015 12:13 PM, Sunil Goutham wrote:
> From: Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>
>
> Signed-off-by: Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>
> Signed-off-by: Sunil Goutham <sgoutham@cavium.com>
> ---
> drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 3 +++
> drivers/net/ethernet/cavium/thunder/thunder_bgx.h | 1 +
> 2 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> index 180aa9f..1fb72dd 100644
> --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> @@ -1009,6 +1009,9 @@ static int bgx_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> struct bgx *bgx = NULL;
> u8 lmac;
>
> + /*Load octeon mdio driver*/
Please insert spaces after /* and before */ (unless it's a common comment
style in this driver).
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/6] net: thunderx: Force to load octeon-mdio before bgx driver.
2015-12-01 13:17 ` Sergei Shtylyov
@ 2015-12-01 16:24 ` Sunil Kovvuri
0 siblings, 0 replies; 3+ messages in thread
From: Sunil Kovvuri @ 2015-12-01 16:24 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Linux Netdev List, LKML, LAKML, Sunil Goutham,
Thanneeru Srinivasulu, Sunil Goutham
Thanks a lot, will fix and repost the patch.
On Tue, Dec 1, 2015 at 6:47 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Hello.
>
> On 12/1/2015 12:13 PM, Sunil Goutham wrote:
>
>> From: Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>
>>
>> Signed-off-by: Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>
>> Signed-off-by: Sunil Goutham <sgoutham@cavium.com>
>> ---
>> drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 3 +++
>> drivers/net/ethernet/cavium/thunder/thunder_bgx.h | 1 +
>> 2 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
>> b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
>> index 180aa9f..1fb72dd 100644
>> --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
>> +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
>> @@ -1009,6 +1009,9 @@ static int bgx_probe(struct pci_dev *pdev, const
>> struct pci_device_id *ent)
>> struct bgx *bgx = NULL;
>> u8 lmac;
>>
>> + /*Load octeon mdio driver*/
>
>
> Please insert spaces after /* and before */ (unless it's a common comment
> style in this driver).
>
> [...]
>
> MBR, Sergei
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-01 16:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-01 9:13 [PATCH 1/6] net: thunderx: Force to load octeon-mdio before bgx driver Sunil Goutham
2015-12-01 13:17 ` Sergei Shtylyov
2015-12-01 16:24 ` Sunil Kovvuri
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).