* [PATCH] xprtrdma: add missing curly braces, set rc to zero on non-zero
@ 2015-11-24 23:11 Colin King
2015-12-02 15:28 ` Anna Schumaker
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2015-11-24 23:11 UTC (permalink / raw)
To: Trond Myklebust, Anna Schumaker, J . Bruce Fields, Jeff Layton,
David S . Miller, Chuck Lever, Sagi Grimberg, Steve Wise,
Doug Ledford, linux-nfs-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
From: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
Add the missing curly braces so that rc is only set to zero when
it is non-zero. Without this minor fix, rc is set to zero even
when it is zero, which is slightly redundant.
Detected with smatch static analysis.
Signed-off-by: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
---
net/sunrpc/xprtrdma/verbs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
index eadd1655..2cc1014 100644
--- a/net/sunrpc/xprtrdma/verbs.c
+++ b/net/sunrpc/xprtrdma/verbs.c
@@ -852,10 +852,11 @@ retry:
if (extras) {
rc = rpcrdma_ep_post_extra_recv(r_xprt, extras);
- if (rc)
+ if (rc) {
pr_warn("%s: rpcrdma_ep_post_extra_recv: %i\n",
__func__, rc);
rc = 0;
+ }
}
}
--
2.6.2
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xprtrdma: add missing curly braces, set rc to zero on non-zero
2015-11-24 23:11 [PATCH] xprtrdma: add missing curly braces, set rc to zero on non-zero Colin King
@ 2015-12-02 15:28 ` Anna Schumaker
0 siblings, 0 replies; 2+ messages in thread
From: Anna Schumaker @ 2015-12-02 15:28 UTC (permalink / raw)
To: Colin King, Trond Myklebust, J . Bruce Fields, Jeff Layton,
David S . Miller, Chuck Lever, Sagi Grimberg, Steve Wise,
Doug Ledford, linux-nfs, netdev, linux-kernel
On 11/24/2015 06:11 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add the missing curly braces so that rc is only set to zero when
> it is non-zero. Without this minor fix, rc is set to zero even
> when it is zero, which is slightly redundant.
>
> Detected with smatch static analysis.
Thanks for the patch, but I've already have a patch from Dan Carpenter queued up to fix this.
Anna
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> net/sunrpc/xprtrdma/verbs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
> index eadd1655..2cc1014 100644
> --- a/net/sunrpc/xprtrdma/verbs.c
> +++ b/net/sunrpc/xprtrdma/verbs.c
> @@ -852,10 +852,11 @@ retry:
>
> if (extras) {
> rc = rpcrdma_ep_post_extra_recv(r_xprt, extras);
> - if (rc)
> + if (rc) {
> pr_warn("%s: rpcrdma_ep_post_extra_recv: %i\n",
> __func__, rc);
> rc = 0;
> + }
> }
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-02 15:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-24 23:11 [PATCH] xprtrdma: add missing curly braces, set rc to zero on non-zero Colin King
2015-12-02 15:28 ` Anna Schumaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).