* [PATCH net-next] PHY: DP83867: Remove looking in parent device for OF properties
@ 2015-12-07 3:38 Andrew Lunn
2015-12-07 3:51 ` Florian Fainelli
2015-12-07 4:06 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Lunn @ 2015-12-07 3:38 UTC (permalink / raw)
To: David Miller; +Cc: Florian Fainelli, netdev, Andrew Lunn
Device tree properties for a phy device are expected to be in the phy
node. The current code for the DP83867 also tries to look in the
parent node. The devices binding documentation does not mention this,
no current device tree file makes use of this, and it is not behaviour
we want. So remove looking in the parent device.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/phy/dp83867.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index 32f10662f4ac..4ebf601073d9 100644
--- a/drivers/net/phy/dp83867.c
+++ b/drivers/net/phy/dp83867.c
@@ -107,10 +107,7 @@ static int dp83867_of_init(struct phy_device *phydev)
struct device_node *of_node = dev->of_node;
int ret;
- if (!of_node && dev->parent->of_node)
- of_node = dev->parent->of_node;
-
- if (!phydev->dev.of_node)
+ if (!of_node)
return -ENODEV;
ret = of_property_read_u32(of_node, "ti,rx-internal-delay",
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] PHY: DP83867: Remove looking in parent device for OF properties
2015-12-07 3:38 [PATCH net-next] PHY: DP83867: Remove looking in parent device for OF properties Andrew Lunn
@ 2015-12-07 3:51 ` Florian Fainelli
2015-12-07 4:06 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2015-12-07 3:51 UTC (permalink / raw)
To: Andrew Lunn, David Miller; +Cc: netdev
Le 06/12/2015 19:38, Andrew Lunn a écrit :
> Device tree properties for a phy device are expected to be in the phy
> node. The current code for the DP83867 also tries to look in the
> parent node. The devices binding documentation does not mention this,
> no current device tree file makes use of this, and it is not behaviour
> we want. So remove looking in the parent device.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks!
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] PHY: DP83867: Remove looking in parent device for OF properties
2015-12-07 3:38 [PATCH net-next] PHY: DP83867: Remove looking in parent device for OF properties Andrew Lunn
2015-12-07 3:51 ` Florian Fainelli
@ 2015-12-07 4:06 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-12-07 4:06 UTC (permalink / raw)
To: andrew; +Cc: f.fainelli, netdev
From: Andrew Lunn <andrew@lunn.ch>
Date: Mon, 7 Dec 2015 04:38:58 +0100
> Device tree properties for a phy device are expected to be in the phy
> node. The current code for the DP83867 also tries to look in the
> parent node. The devices binding documentation does not mention this,
> no current device tree file makes use of this, and it is not behaviour
> we want. So remove looking in the parent device.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-07 4:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-07 3:38 [PATCH net-next] PHY: DP83867: Remove looking in parent device for OF properties Andrew Lunn
2015-12-07 3:51 ` Florian Fainelli
2015-12-07 4:06 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).