From: Tilman Schmidt <tilman@imap.cc>
To: Paul Bolle <pebolle@tiscali.nl>,
Peter Hurley <peter@hurleysoftware.com>,
Sasha Levin <sasha.levin@oracle.com>
Cc: isdn@linux-pingi.de, davem@davemloft.net,
gigaset307x-common@lists.sourceforge.net,
LKML <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
syzkaller <syzkaller@googlegroups.com>
Subject: Re: gigaset: freeing an active object
Date: Mon, 7 Dec 2015 19:40:55 +0100 [thread overview]
Message-ID: <5665D2B7.3040409@imap.cc> (raw)
In-Reply-To: <1449491141.3615.11.camel@tiscali.nl>
[-- Attachment #1: Type: text/plain, Size: 1065 bytes --]
Am 07.12.2015 um 13:25 schrieb Paul Bolle:
>>> Otherwise we'd still be freeing memory
>>> managed through reference counting.
>>
>> Now I#m confused. I thought by following Peter's suggestion to put the
>> kfree() in the release method we'd avoid just that.
>
> Apparently it does, because I can't trigger the WARNING we're discussing
> here with your patch applied.
Nice.
> I'll have to dive into this stuff again,
> because apparently my mental model of what's going on is incomplete at
> best.
I won't claim anything like completeness for mine.
> In the mean time you might want to turn your patch into something that
> can actually be applied (with or without my Sign-off or Ack; I don't
> care how it finds its way into the tree). Please add add
> Fixes: 2869b23e4b95 ("[PATCH] drivers/isdn/gigaset: new M101 driver (v2)")
Will do. (Not today, though.)
Regards,
Tilman
--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Nous, on a des fleurs et des bougies pour nous protéger.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-12-07 18:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 15:19 gigaset: freeing an active object Sasha Levin
2015-11-27 17:57 ` Paul Bolle
2015-11-27 18:15 ` Sasha Levin
2015-11-28 0:28 ` Paul Bolle
2015-11-28 1:20 ` Peter Hurley
2015-11-28 1:27 ` Sasha Levin
2015-11-29 14:36 ` Dmitry Vyukov
2015-11-29 15:30 ` Tilman Schmidt
2015-11-29 18:22 ` Peter Hurley
2015-11-29 18:38 ` Tilman Schmidt
2015-11-29 18:47 ` Tilman Schmidt
2015-11-29 20:26 ` Paul Bolle
2015-11-29 23:23 ` Paul Bolle
2015-11-30 18:01 ` Paul Bolle
2015-11-30 18:30 ` Tilman Schmidt
2015-11-30 21:07 ` Paul Bolle
2015-12-01 9:30 ` Tilman Schmidt
2015-12-01 10:05 ` Paul Bolle
2015-12-02 23:48 ` Peter Hurley
2015-12-06 13:31 ` Paul Bolle
2015-12-06 15:29 ` Tilman Schmidt
2015-12-06 20:12 ` Paul Bolle
2015-12-07 9:27 ` Tilman Schmidt
2015-12-07 12:25 ` Paul Bolle
2015-12-07 18:40 ` Tilman Schmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5665D2B7.3040409@imap.cc \
--to=tilman@imap.cc \
--cc=davem@davemloft.net \
--cc=gigaset307x-common@lists.sourceforge.net \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=peter@hurleysoftware.com \
--cc=sasha.levin@oracle.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).