From: David Ahern <dsa@cumulusnetworks.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, shm@cumulusnetworks.com,
roopa@cumulusnetworks.com
Subject: Re: [PATCH net-next v3] net: Add fib rules at vrf device create
Date: Wed, 9 Dec 2015 15:05:06 -0700 [thread overview]
Message-ID: <5668A592.3080104@cumulusnetworks.com> (raw)
In-Reply-To: <20151209.151309.1866782058292162458.davem@davemloft.net>
On 12/9/15 1:13 PM, David Miller wrote:
> The new attributes make things more complex, because ever _VALID_ tool
> much accomodate the existing situation and be able to perform all of
> the commands above if they are executed on an older kernel.
>
> So the new attributes make things worse, not better.
Dave, how does this make it more complex - beyond the complexity of
giving a user choices?
If a user wants to install rules directly go for it. That path works
fine. That covers whatever user base has popped up over the last 38 days
for the IPv4 support in v4.3 and who ever starts on v4.4 with IPv6 support.
With this change if a user wants the driver to take care of the details
it can -- by the user asking for the driver to deal with the details.
The 2 options peacefully co-exist.
>
> I will ignore all further attempts to find schemes automate the rule
> and route additions, because it is simply the wrong way forward.
You want to say I failed by not including this in the first patch set -
fine blame accepted. The initial patches focused on core infrastructure
to enable VRF support in Linux -- a subject which has proved tough
enough over the past 15 years.
next prev parent reply other threads:[~2015-12-09 22:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 17:43 [PATCH net-next v3] net: Add fib rules at vrf device create David Ahern
2015-12-09 20:13 ` David Miller
2015-12-09 22:05 ` David Ahern [this message]
2015-12-09 22:22 ` David Miller
2015-12-09 23:04 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5668A592.3080104@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=shm@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).