[PATCH] ixgbe: on recv increment rx.ring->stats.yields instead of tx

[PATCH] ixgbe: on recv increment rx.ring->stats.yields instead of tx

[Pavel Tikhomirov]

It seem to be non intentionaly changed to tx in
ms commit: adc810900a703ee78fe88fd65e086d359fec04b2
ixgbe: Refactor busy poll socket code to address multiple issues

Lock is taken from ixgbe_low_latency_recv, and there under this
lock we use ixgbe_clean_rx_irq so it looks wrong for me to increment
tx counter.

Yield stats can be shown through ethtool:
ethtool -S enp129s0 | grep yield

Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
index 1d21745..7656d46 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
@@ -451,7 +451,7 @@ static inline bool ixgbe_qv_lock_poll(struct ixgbe_q_vector *q_vector)
 				IXGBE_QV_STATE_POLL);
 #ifdef BP_EXTENDED_STATS
 	if (rc != IXGBE_QV_STATE_IDLE)
-		q_vector->tx.ring->stats.yields++;
+		q_vector->rx.ring->stats.yields++;
 #endif
 	return rc == IXGBE_QV_STATE_IDLE;
 }
-- 
1.9.3

Re: [PATCH] ixgbe: on recv increment rx.ring->stats.yields instead of tx

[Sergei Shtylyov]

Hello.

On 12/11/2015 10:24 AM, Pavel Tikhomirov wrote:

> It seem to be non intentionaly changed to tx in
> ms commit: adc810900a703ee78fe88fd65e086d359fec04b2
> ixgbe: Refactor busy poll socket code to address multiple issues

    scripts/checkpatch.pl now enforces uniform style of the commit citing, 
please follow.

> Lock is taken from ixgbe_low_latency_recv, and there under this
> lock we use ixgbe_clean_rx_irq so it looks wrong for me to increment
> tx counter.
>
> Yield stats can be shown through ethtool:
> ethtool -S enp129s0 | grep yield
>
> Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
[...]

MBR, Sergei

[PATCH v2] ixgbe: on recv increment rx.ring->stats.yields

[Pavel Tikhomirov]

It seem to be non intentionaly changed to tx in
commit adc810900a70 ("ixgbe: Refactor busy poll socket code to address
multiple issues")

Lock is taken from ixgbe_low_latency_recv, and there under this
lock we use ixgbe_clean_rx_irq so it looks wrong for me to increment
tx counter.

Yield stats can be shown through ethtool:
ethtool -S enp129s0 | grep yield

v2: follow commit citing style

Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
index 1d21745..7656d46 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
@@ -451,7 +451,7 @@ static inline bool ixgbe_qv_lock_poll(struct ixgbe_q_vector *q_vector)
 				IXGBE_QV_STATE_POLL);
 #ifdef BP_EXTENDED_STATS
 	if (rc != IXGBE_QV_STATE_IDLE)
-		q_vector->tx.ring->stats.yields++;
+		q_vector->rx.ring->stats.yields++;
 #endif
 	return rc == IXGBE_QV_STATE_IDLE;
 }
-- 
1.9.3

Re: [Intel-wired-lan] [PATCH v2] ixgbe: on recv increment rx.ring->stats.yields

[Pavel Tikhomirov]

Hi, please, let me know if I need to fix something else here.

On 12/11/2015 05:05 PM, Pavel Tikhomirov wrote:
> It seem to be non intentionaly changed to tx in
> commit adc810900a70 ("ixgbe: Refactor busy poll socket code to address
> multiple issues")
>
> Lock is taken from ixgbe_low_latency_recv, and there under this
> lock we use ixgbe_clean_rx_irq so it looks wrong for me to increment
> tx counter.
>
> Yield stats can be shown through ethtool:
> ethtool -S enp129s0 | grep yield
>
> v2: follow commit citing style
>
> Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
> ---
>   drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
> index 1d21745..7656d46 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
> @@ -451,7 +451,7 @@ static inline bool ixgbe_qv_lock_poll(struct ixgbe_q_vector *q_vector)
>   				IXGBE_QV_STATE_POLL);
>   #ifdef BP_EXTENDED_STATS
>   	if (rc != IXGBE_QV_STATE_IDLE)
> -		q_vector->tx.ring->stats.yields++;
> +		q_vector->rx.ring->stats.yields++;
>   #endif
>   	return rc == IXGBE_QV_STATE_IDLE;
>   }
>

-- 
Best regards, Tikhomirov Pavel
Software Developer, Virtuozzo.