From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Igor Gavrilov <i.o.gavrilov@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH ]net: sched/cls_flow.c : allow nfct-* keys work on ingress interfaces
Date: Sun, 13 Dec 2015 09:01:42 -0500 [thread overview]
Message-ID: <566D7A46.5090008@mojatatu.com> (raw)
In-Reply-To: <CADo-kffbKruR9zqCQj2qp4Z8CHzJJCo0sm94VCg2tAS=XbSJqQ@mail.gmail.com>
Hi Igor,
On 15-12-11 04:55 AM, Igor Gavrilov wrote:
> Improved CTTUPLE macro with code from sched/act_connmark.c, so it be
> able to get unNATed addresses from nf_conntrack.
>
1) Question: Have you tested the patch or you just cutnpasted
from connmark.c? By inspection the patch looks ok technically
but if you havent tested, please verify it.
2)The macros have indentation issues around
if (ct == NULL) {} else { }
just use the proper indent rules.
3) Please use proper formatting on submitting patches (such as putting
the From at the top etc). Look at:
Maybe you should use git facilities?
If you meet all the above requirements, please resubmit and
add my Acked-by
cheers,
jamal
prev parent reply other threads:[~2015-12-13 14:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 9:55 [PATCH ]net: sched/cls_flow.c : allow nfct-* keys work on ingress interfaces Igor Gavrilov
2015-12-13 14:01 ` Jamal Hadi Salim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566D7A46.5090008@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=i.o.gavrilov@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).