* [PATCH 1/1] net: bonding: remove redudant brackets
@ 2015-12-03 10:00 Zhu Yanjun
0 siblings, 0 replies; 4+ messages in thread
From: Zhu Yanjun @ 2015-12-03 10:00 UTC (permalink / raw)
To: netdev, davem
It is not necessary to use two brackets. As such, the redudant brackets
are removed.
CC: Jay Vosburgh <j.vosburgh@gmail.com>
CC: Veaceslav Falico <vfalico@gmail.com>
CC: Andy Gospodarek <gospo@cumulusnetworks.com>
Signed-off-by: Zhu Yanjun <yanjun.zhu@windriver.com>
---
drivers/net/bonding/bond_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 9e0f8a7..09f8a48 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1351,7 +1351,7 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev)
* the current ifenslave will set the interface down prior to
* enslaving it; the old ifenslave will not.
*/
- if ((slave_dev->flags & IFF_UP)) {
+ if (slave_dev->flags & IFF_UP) {
netdev_err(bond_dev, "%s is up - this may be due to an out of date ifenslave\n",
slave_dev->name);
res = -EPERM;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/1] net: bonding: remove redudant brackets
@ 2015-12-09 3:30 zyjzy2000
2015-12-12 1:03 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: zyjzy2000 @ 2015-12-09 3:30 UTC (permalink / raw)
To: j.vosburgh, vfalico, gospo, netdev
From: yzhu1 <zyzy2000@gmail.com>
It is not necessary to use two brackets. As such, the redudant brackets
are removed.
CC: Jay Vosburgh <j.vosburgh@gmail.com>
CC: Veaceslav Falico <vfalico@gmail.com>
CC: Andy Gospodarek <gospo@cumulusnetworks.com>
Signed-off-by: yzhu1 <zyzyj2000@gmail.com>
---
drivers/net/bonding/bond_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 9e0f8a7..09f8a48 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1351,7 +1351,7 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev)
* the current ifenslave will set the interface down prior to
* enslaving it; the old ifenslave will not.
*/
- if ((slave_dev->flags & IFF_UP)) {
+ if (slave_dev->flags & IFF_UP) {
netdev_err(bond_dev, "%s is up - this may be due to an out of date ifenslave\n",
slave_dev->name);
res = -EPERM;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] net: bonding: remove redudant brackets
2015-12-09 3:30 [PATCH 1/1] net: bonding: remove redudant brackets zyjzy2000
@ 2015-12-12 1:03 ` David Miller
2015-12-14 14:06 ` Nicolas Dichtel
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2015-12-12 1:03 UTC (permalink / raw)
To: zyjzy2000; +Cc: j.vosburgh, vfalico, gospo, netdev
From: <zyjzy2000@gmail.com>
Date: Wed, 9 Dec 2015 11:30:42 +0800
> From: yzhu1 <zyzy2000@gmail.com>
>
> It is not necessary to use two brackets. As such, the redudant brackets
> are removed.
>
> CC: Jay Vosburgh <j.vosburgh@gmail.com>
> CC: Veaceslav Falico <vfalico@gmail.com>
> CC: Andy Gospodarek <gospo@cumulusnetworks.com>
> Signed-off-by: yzhu1 <zyzyj2000@gmail.com>
Does not apply to the net-next tree.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] net: bonding: remove redudant brackets
2015-12-12 1:03 ` David Miller
@ 2015-12-14 14:06 ` Nicolas Dichtel
0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Dichtel @ 2015-12-14 14:06 UTC (permalink / raw)
To: David Miller, zyjzy2000; +Cc: j.vosburgh, vfalico, gospo, netdev
Le 12/12/2015 02:03, David Miller a écrit :
> From: <zyjzy2000@gmail.com>
>> From: yzhu1 <zyzy2000@gmail.com>
>> Signed-off-by: yzhu1 <zyzyj2000@gmail.com>
>
> Does not apply to the net-next tree.
Also three different emails ...
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-14 14:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-09 3:30 [PATCH 1/1] net: bonding: remove redudant brackets zyjzy2000
2015-12-12 1:03 ` David Miller
2015-12-14 14:06 ` Nicolas Dichtel
-- strict thread matches above, loose matches on Subject: below --
2015-12-03 10:00 Zhu Yanjun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).