From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net] ravb: Add disable 10base Date: Mon, 14 Dec 2015 10:49:56 -0800 Message-ID: <566F0F54.8060909@gmail.com> References: <1450019758-32710-1-git-send-email-ykaneko0929@gmail.com> <566DA83C.9080801@cogentembedded.com> <20151214045301.GA18143@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Yoshihiro Kaneko , netdev@vger.kernel.org, "David S. Miller" , Magnus Damm , linux-sh@vger.kernel.org To: Simon Horman , Sergei Shtylyov Return-path: In-Reply-To: <20151214045301.GA18143@verge.net.au> Sender: linux-sh-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 13/12/15 20:53, Simon Horman wrote: > [Cc Florian] > > On Sun, Dec 13, 2015 at 08:17:48PM +0300, Sergei Shtylyov wrote: >> Hello. >> >> On 12/13/2015 06:15 PM, Yoshihiro Kaneko wrote: >> >>> From: Kazuya Mizuguchi >>> >>> Ethernet AVB does not support 10 Mbps transfer speed. >>> >>> Signed-off-by: Kazuya Mizuguchi >>> Signed-off-by: Yoshihiro Kaneko >>> --- >>> >>> This patch is based on the master branch of David Miller's networking >>> tree. >>> >>> drivers/net/ethernet/renesas/ravb_main.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c >>> index b69e0c2..467d416 100644 >>> --- a/drivers/net/ethernet/renesas/ravb_main.c >>> +++ b/drivers/net/ethernet/renesas/ravb_main.c >>> @@ -905,6 +905,9 @@ static int ravb_phy_init(struct net_device *ndev) >>> netdev_info(ndev, "limited PHY to 100Mbit/s\n"); >>> } >>> >>> + /* 10BASE is not supported */ >>> + phydev->supported &= ~PHY_10BT_FEATURES; >>> + >> >> Perhaps we need phy_set_min_speed() in addition to phy_set_max_speed()? > > FWIW, as the person who added phy_set_max_speed(), I think > that is sounds like a good idea. I am not opposed to the idea, but so far, it seems like setting the minimum supported speed was a little less frequent than setting the maximum speed. Feel free to submit a patch though if you think/know there are other drivers potentially using this. -- Florian