From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh_eth: fix descriptor access endianness
Date: Tue, 15 Dec 2015 14:26:51 +0300 [thread overview]
Message-ID: <566FF8FB.2010005@cogentembedded.com> (raw)
In-Reply-To: <20151215.002541.762812772082527155.davem@davemloft.net>
Hello.
On 12/15/2015 8:25 AM, David Miller wrote:
>> The driver never calls cpu_to_edmac() when writing the descriptor address
>> and edmac_to_cpu() when reading it, although it should -- fix this.
>>
>> Note that the frame/buffer length descriptor field accesses also need fixing
>> but since they are both 16-bit we can't use {cpu|edmac}_to_{edmac|cpu}()...
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> Applied.
I was going to rework this to fix _all_ cases, and sent follow-up email
about that yesterday... Haven't you received it?
MBR, Sergei
next prev parent reply other threads:[~2015-12-15 11:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-13 20:05 [PATCH] sh_eth: fix descriptor access endianness Sergei Shtylyov
2015-12-14 16:53 ` Sergei Shtylyov
2015-12-15 5:25 ` David Miller
2015-12-15 11:26 ` Sergei Shtylyov [this message]
2015-12-15 17:53 ` David Miller
2015-12-15 18:06 ` Sergei Shtylyov
2015-12-15 18:26 ` David Miller
2015-12-15 19:02 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566FF8FB.2010005@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).