From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shannon Nelson Subject: Re: [PATCH net-next] liquidio: fix kernel panic when NIC firmware is older than 1.7.2 Date: Tue, 26 Jun 2018 09:03:25 -0700 Message-ID: <5670609b-5056-305d-ee0f-8fed471d8381@oracle.com> References: <20180626115807.GA7089@felix-thinkpad.cavium.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, raghu.vatsavayi@cavium.com, derek.chickles@cavium.com, satananda.burla@cavium.com, ricardo.farrington@cavium.com To: Felix Manlunas , davem@davemloft.net Return-path: Received: from userp2130.oracle.com ([156.151.31.86]:57450 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752716AbeFZQDe (ORCPT ); Tue, 26 Jun 2018 12:03:34 -0400 In-Reply-To: <20180626115807.GA7089@felix-thinkpad.cavium.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 6/26/2018 4:58 AM, Felix Manlunas wrote: > From: Rick Farrington > > Pre-1.7.2 NIC firmware does not support (and does not respond to) the "get > speed" command which is sent by the 1.7.2 driver during modprobe. Due to a > bug in older firmware (with respect to unknown commands), this unsupported > command causes a cascade of errors that ends in a kernel panic. > > Fix it by making the sending of the "get speed" command conditional on the > firmware version. > > Signed-off-by: Rick Farrington > Acked-by: Derek Chickles > Signed-off-by: Felix Manlunas > --- > Note: To avoid checkpatch.pl "WARNING: line over 80 characters", the comma > that separates the arguments in the call to strcmp() was placed one > line below the usual spot. > > drivers/net/ethernet/cavium/liquidio/lio_main.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c > index 7cb4e75..f83f884 100644 > --- a/drivers/net/ethernet/cavium/liquidio/lio_main.c > +++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c > @@ -3671,7 +3671,16 @@ static int setup_nic_devices(struct octeon_device *octeon_dev) > OCTEON_CN2350_25GB_SUBSYS_ID || > octeon_dev->subsystem_id == > OCTEON_CN2360_25GB_SUBSYS_ID) { > - liquidio_get_speed(lio); > + /* speed control unsupported in f/w older than 1.7.2 */ > + if (strcmp(octeon_dev->fw_info.liquidio_firmware_version > + , "1.7.2") < 0) { Will the liquidio_firmware_version ever end up something like 1.7.10? If so, this strcmp() may not do what you want. sln > + dev_info(&octeon_dev->pci_dev->dev, > + "speed setting not supported by f/w."); > + octeon_dev->speed_setting = 25; > + octeon_dev->no_speed_setting = 1; > + } else { > + liquidio_get_speed(lio); > + } > > if (octeon_dev->speed_setting == 0) { > octeon_dev->speed_setting = 25; >