From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vijay Khemka Subject: Re: [PATCH net-next 1/2] net/ncsi: Add NCSI Broadcom OEM command Date: Mon, 8 Oct 2018 19:18:04 +0000 Message-ID: <567088A2-66B2-45FD-A2CA-46E476BFC856@fb.com> References: <20181005190126.983734-1-vijaykhemka@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "openbmc @ lists . ozlabs . org" , "Justin . Lee1 @ Dell . com" , "joel @ jms . id . au" , "linux-aspeed @ lists . ozlabs . org" , Sai Dasari , "christian @ cmd . nu" To: Samuel Mendoza-Jonas , "David S. Miller" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Return-path: In-Reply-To: Content-Language: en-US Content-ID: <6CC8532C41E096469B09DC2C9547B3A5@namprd15.prod.outlook.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org DQoNCu+7v09uIDEwLzcvMTgsIDU6NTggUE0sICJTYW11ZWwgTWVuZG96YS1Kb25hcyIgPHNhbUBt ZW5kb3pham9uYXMuY29tPiB3cm90ZToNCg0KICAgIE9uIEZyaSwgMjAxOC0xMC0wNSBhdCAxMjow MSAtMDcwMCwgVmlqYXkgS2hlbWthIHdyb3RlOg0KICAgID4gVGhpcyBwYXRjaCBhZGRzIE9FTSBC cm9hZGNvbSBjb21tYW5kcyBhbmQgcmVzcG9uc2UgaGFuZGxpbmcuIEl0IGFsc28NCiAgICA+IGRl ZmluZXMgT0VNIEdldCBNQUMgQWRkcmVzcyBoYW5kbGVyIHRvIGdldCBhbmQgY29uZmlndXJlIHRo ZSBkZXZpY2UuDQogICAgPiANCiAgICA+IG5jc2lfb2VtX2dtYV9oYW5kbGVyX2JjbTogVGhpcyBo YW5kbGVyIHNlbmQgTkNTSSBicm9hZGNvbSBjb21tYW5kIGZvcg0KICAgID4gZ2V0dGluZyBtYWMg YWRkcmVzcy4NCiAgICA+IG5jc2lfcnNwX2hhbmRsZXJfb2VtX2JjbTogVGhpcyBoYW5kbGVzIHJl c3BvbnNlIHJlY2VpdmVkIGZvciBhbGwNCiAgICA+IGJyb2FkY29tIE9FTSBjb21tYW5kcy4NCiAg ICA+IG5jc2lfcnNwX2hhbmRsZXJfb2VtX2JjbV9nbWE6IFRoaXMgaGFuZGxlcyBnZXQgbWFjIGFk ZHJlc3MgcmVzcG9uc2UgYW5kDQogICAgPiBzZXQgaXQgdG8gZGV2aWNlLg0KICAgID4gDQogICAg PiBTaWduZWQtb2ZmLWJ5OiBWaWpheSBLaGVta2EgPHZpamF5a2hlbWthQGZiLmNvbT4NCiAgICAN CiAgICBIaSBWaWpheSwNCiAgICANCiAgICBMb29rcyBnb29kLCBhbmQgSSd2ZSB0ZXN0ZWQgdGhp cyBvbiBhIEJNQyB3aXRoIGEgQnJvYWRjb20gbmV0d29yaw0KICAgIGNvbnRyb2xsZXIgYW5kIGl0 IHByb3Blcmx5IHNldHMgYSBNQUMgYWRkcmVzcy4gQSBxdWVzdGlvbiBiZWxvdyBhYm91dCB0aGUN CiAgICByZXNwb25zZSBoYW5kbGVyOg0KDQogIEhpIFNhbSwNCiAgVGhhbmtzIGZvciBmZWVkYmFj aywgSSB3aWxsIHVwZGF0ZSBjb2RlIGZvciByZXNwb25zZSBoYW5kbGVyLiBQbGVhc2Ugc2VlIG15 IHJlc3BvbnNlIGJlbG93Lg0KICAgIA0KDQogICAgPiArLyogUmVzcG9uc2UgaGFuZGxlciBmb3Ig QnJvYWRjb20gY29tbWFuZCBHZXQgTWFjIEFkZHJlc3MgKi8NCiAgICA+ICtzdGF0aWMgaW50IG5j c2lfcnNwX2hhbmRsZXJfb2VtX2JjbV9nbWEoc3RydWN0IG5jc2lfcmVxdWVzdCAqbnIpDQogICAg PiArew0KICAgID4gKwlzdHJ1Y3QgbmNzaV9yc3Bfb2VtX3BrdCAqcnNwOw0KICAgID4gKwlzdHJ1 Y3QgbmNzaV9kZXZfcHJpdiAqbmRwID0gbnItPm5kcDsNCiAgICA+ICsJc3RydWN0IG5ldF9kZXZp Y2UgKm5kZXYgPSBuZHAtPm5kZXYuZGV2Ow0KICAgID4gKwlpbnQgcmV0ID0gMDsNCiAgICA+ICsJ Y29uc3Qgc3RydWN0IG5ldF9kZXZpY2Vfb3BzICpvcHMgPSBuZGV2LT5uZXRkZXZfb3BzOw0KICAg ID4gKwlzdHJ1Y3Qgc29ja2FkZHIgc2FkZHI7DQogICAgPiArDQogICAgPiArCS8qIEdldCB0aGUg cmVzcG9uc2UgaGVhZGVyICovDQogICAgPiArCXJzcCA9IChzdHJ1Y3QgbmNzaV9yc3Bfb2VtX3Br dCAqKXNrYl9uZXR3b3JrX2hlYWRlcihuci0+cnNwKTsNCiAgICA+ICsNCiAgICA+ICsJc2FkZHIu c2FfZmFtaWx5ID0gbmRldi0+dHlwZTsNCiAgICA+ICsJbmRldi0+cHJpdl9mbGFncyB8PSBJRkZf TElWRV9BRERSX0NIQU5HRTsNCiAgICA+ICsJbWVtY3B5KHNhZGRyLnNhX2RhdGEsICZyc3AtPmRh dGFbQkNNX01BQ19BRERSX09GRlNFVF0sIEVUSF9BTEVOKTsNCiAgICA+ICsJLyogSW5jcmVhc2Ug bWFjIGFkZHJlc3MgYnkgMSBmb3IgQk1DJ3MgYWRkcmVzcyAqLw0KICAgID4gKwlzYWRkci5zYV9k YXRhW0VUSF9BTEVOIC0gMV0rKzsNCiAgICANCiAgICBJcyB0aGlzIGNvbnZlbnRpb24gZG9jdW1l bnRlZCBzb21ld2hlcmUsIGFuZCBjb3VsZCB5b3UgcHJvdmlkZSBhIGxpbmsgdG8NCiAgICBpdCBp ZiBzbz8NCiAgICANCiAgICBBbHNvIHdoYXQgaGFwcGVucyBoZXJlIGlmIHRoZSBmaW5hbCBieXRl IG9mIHRoZSBhZGRyZXNzIGlzIDB4ZmYsIHRoaXMNCiAgICB3aWxsIG92ZXJmbG93IGFuZCBub3Qg Y2FycnkgcmlnaHQ/DQoNCiAgVGhpcyBpcyBhIEZhY2Vib29rIHJlcXVpcmVtZW50IHRvIGluY3Jl bWVudCBNQUMgYWRkcmVzcyBieSAxIGFzIGJhc2UgYWRkcmVzcyBpcyBkZWZpbmVkIGZvciANCiAg c2VydmVyIGZvbGxvd2VkIGJ5IEJNQyBhZGRyZXNzLiBJIHdpbGwgaGFuZGxlIHRoaXMgRmFjZWJv b2sgc3BlY2lmaWMgY29kZSBkaWZmZXJlbnRseSBpbiBuZXcgDQogIHBhdGNoLiBGb3IgZ2VuZXJp YyBCcm9hZGNvbSBjYXJkLCBJIHdpbGwganVzdCBnZXQgYmFzZSBtYWMgYWRkcmVzcyBhbmQgbm90 IGFkZCBhbnkgY29udmVudGlvbi4NCiAgICANCiAgICA+ICsJcmV0ID0gb3BzLT5uZG9fc2V0X21h Y19hZGRyZXNzKG5kZXYsICZzYWRkcik7DQogICAgPiArCWlmIChyZXQgPCAwKQ0KICAgID4gKwkJ bmV0ZGV2X3dhcm4obmRldiwgIk5DU0k6ICdXcml0aW5nIG1hYyBhZGRyZXNzIHRvIGRldmljZSBm YWlsZWRcbiIpOw0KICAgIA0KICAgIEFsc28gYSBtaW5vciBuaXRwaWNrLCB0aGVyZSdzIGEgYm9u dXMgIiciIGluIHRoaXMgbWVzc2FnZS4NCiAgICANCiAgV2lsbCBiZSB0YWtlbiBjYXJlIGluIG5l eHQgdmVyc2lvbi4NCiAgICANCg0K