From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Frederic Sowa Subject: Re: [PATCH iproute2] ipv6: allow setting stable_secret mode Date: Wed, 16 Dec 2015 18:04:34 +0100 Message-ID: <567199A2.3050305@stressinduktion.org> References: <1450265408-20510-1-git-send-email-hannes@stressinduktion.org> <64C7B1E3-1F0C-4472-91A9-9D6DE5206D6A@mork.no> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: stephen@networkplumber.org To: =?UTF-8?Q?Bj=c3=b8rn_Mork?= , netdev@vger.kernel.org Return-path: Received: from out1-smtp.messagingengine.com ([66.111.4.25]:36383 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753701AbbLPREg (ORCPT ); Wed, 16 Dec 2015 12:04:36 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 5DE1F205A3 for ; Wed, 16 Dec 2015 12:04:36 -0500 (EST) In-Reply-To: <64C7B1E3-1F0C-4472-91A9-9D6DE5206D6A@mork.no> Sender: netdev-owner@vger.kernel.org List-ID: On 16.12.2015 17:56, Bj=C3=B8rn Mork wrote: >=20 >=20 > On December 16, 2015 12:30:08 PM CET, Hannes Frederic Sowa wrote: >> Signed-off-by: Hannes Frederic Sowa >> --- >> ip/iplink.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/ip/iplink.c b/ip/iplink.c >> index f30de86d1858a0..e824082f7d8149 100644 >> --- a/ip/iplink.c >> +++ b/ip/iplink.c >> @@ -84,7 +84,7 @@ void iplink_usage(void) >> fprintf(stderr, " [ state { auto | enable | disable} ] ]\n"); >> fprintf(stderr, " [ master DEVICE ]\n"); >> fprintf(stderr, " [ nomaster ]\n"); >> - fprintf(stderr, " [ addrgenmode { eui64 | none } ]\n"); >> + fprintf(stderr, " [ addrgenmode { eui64 | none | stable_secret= } >> ]\n"); >> fprintf(stderr, " [ protodown { on | off } ]\n"); >> fprintf(stderr, " ip link show [ DEVICE | group GROUP ] [up] >> [master DEV] [type TYPE]\n"); >> >> @@ -176,6 +176,8 @@ static int get_addr_gen_mode(const char *mode) >> return IN6_ADDR_GEN_MODE_EUI64; >> if (strcasecmp(mode, "none") =3D=3D 0) >> return IN6_ADDR_GEN_MODE_NONE; >> + if (strcasecmp(mode, "stable_secret") =3D=3D 0) >> + return IN6_ADDR_GEN_MODE_STABLE_PRIVACY; >> return -1; >> } >> >=20 > Ah, didn't notice this before I sent my similar patch. Sorry about th= at. >=20 > But FWIW, I really don't like the renaming you do here.=20 > If the mode is 'stable_privacy', then it should be known > by that name here as well. I am fine with both ways. We can take your patch as you also updated th= e man page. :) The reason why I chose stable secret in the end was to align it with th= e already visible proc filename stable_secret and didn't care too much about the internal variable names. Thanks, Hannes