From: Bert Kenward <bkenward@solarflare.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>,
Solarflare linux maintainers <linux-net-drivers@solarflare.com>,
Tomas Pilar <tpilar@solarflare.com>
Subject: [PATCH net-next 4/5] sfc: Downgrade EPERM messages from MCDI to debug
Date: Fri, 18 Dec 2015 17:09:57 +0000 [thread overview]
Message-ID: <56743DE5.80609@solarflare.com> (raw)
In-Reply-To: <56743D6A.5020605@solarflare.com>
From: Tomáš Pilař <tpilar@solarflare.com>
When running in an unprivileged function we expect some MC commands
to fail with permission errors. To avoid log spew downgrade these to
debug only.
Signed-off-by: Bert Kenward <bkenward@solarflare.com>
---
drivers/net/ethernet/sfc/mcdi.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/sfc/mcdi.c b/drivers/net/ethernet/sfc/mcdi.c
index ab68ff6..7df183a 100644
--- a/drivers/net/ethernet/sfc/mcdi.c
+++ b/drivers/net/ethernet/sfc/mcdi.c
@@ -1084,9 +1084,10 @@ void efx_mcdi_display_error(struct efx_nic *efx, unsigned cmd,
code = MCDI_DWORD(outbuf, ERR_CODE);
if (outlen >= MC_CMD_ERR_ARG_OFST + 4)
err_arg = MCDI_DWORD(outbuf, ERR_ARG);
- netif_err(efx, hw, efx->net_dev,
- "MC command 0x%x inlen %d failed rc=%d (raw=%d) arg=%d\n",
- cmd, (int)inlen, rc, code, err_arg);
+ netif_printk(efx, hw, rc == -EPERM ? KERN_DEBUG : KERN_ERR,
+ efx->net_dev,
+ "MC command 0x%x inlen %zu failed rc=%d (raw=%d) arg=%d\n",
+ cmd, inlen, rc, code, err_arg);
}
/* Switch to polled MCDI completions. This can be called in various
--
2.4.3
next prev parent reply other threads:[~2015-12-18 17:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 17:07 [PATCH net-next 0/5] sfc: additional virtual function support Bert Kenward
2015-12-18 17:08 ` [PATCH net-next 1/5] sfc: Retry MCDI after NO_EVB_PORT error on a VF Bert Kenward
2015-12-18 17:09 ` [PATCH net-next 2/5] sfc: Handle MCDI proxy authorisation Bert Kenward
2015-12-22 20:08 ` David Miller
2015-12-18 17:09 ` [PATCH net-next 3/5] sfc: Make failed filter removal less noisy Bert Kenward
2015-12-18 17:09 ` Bert Kenward [this message]
2015-12-18 17:10 ` [PATCH net-next 5/5] sfc: Downgrade or remove some error messages Bert Kenward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56743DE5.80609@solarflare.com \
--to=bkenward@solarflare.com \
--cc=davem@davemloft.net \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=tpilar@solarflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).