From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Pravin B Shelar <pshelar@nicira.com>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] ip_tunnel: Move stats update to iptunnel_xmit()
Date: Thu, 24 Dec 2015 10:21:27 +0100 [thread overview]
Message-ID: <567BB917.9090900@6wind.com> (raw)
In-Reply-To: <1450914723-16452-1-git-send-email-pshelar@nicira.com>
Le 24/12/2015 00:52, Pravin B Shelar a écrit :
[snip]
> diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c
> index 6af78c6..d63a911 100644
> --- a/net/tipc/udp_media.c
> +++ b/net/tipc/udp_media.c
> @@ -182,15 +182,9 @@ static int tipc_udp_send_msg(struct net *net, struct sk_buff *skb,
> goto tx_error;
> }
> ttl = ip4_dst_hoplimit(&rt->dst);
> - err = udp_tunnel_xmit_skb(rt, ub->ubsock->sk, skb,
> - src->ipv4.s_addr,
> - dst->ipv4.s_addr, 0, ttl, 0,
> - src->udp_port, dst->udp_port,
> - false, true);
> - if (err < 0) {
> - ip_rt_put(rt);
> - goto tx_error;
> - }
> + udp_tunnel_xmit_skb(rt, ub->ubsock->sk, skb, src->ipv4.s_addr,
> + dst->ipv4.s_addr, 0, ttl, 0, src->udp_port,
> + dst->udp_port, false, true);
I don't know how tipc works, but this change is clearly suspect. What make the
error path not needed anymore after your patch?
next prev parent reply other threads:[~2015-12-24 9:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 23:52 [PATCH net-next v2] ip_tunnel: Move stats update to iptunnel_xmit() Pravin B Shelar
2015-12-24 2:57 ` David Miller
2015-12-24 4:37 ` Pravin Shelar
2015-12-24 9:03 ` Nicolas Dichtel
2015-12-24 9:14 ` Nicolas Dichtel
2015-12-24 22:36 ` Pravin Shelar
2015-12-24 9:21 ` Nicolas Dichtel [this message]
2015-12-24 12:46 ` Thadeu Lima de Souza Cascardo
2015-12-24 14:17 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567BB917.9090900@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).