From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Pismenny Subject: Re: [PATCH net 2/3] tls: clear key material from kernel memory when do_tls_setsockopt_conf fails Date: Wed, 5 Sep 2018 16:53:54 +0300 Message-ID: <567f747b-e817-4a9b-1768-96575caea845@mellanox.com> References: <695fc3449c2ba927e97abd48b452a31ec73d6c61.1536152698.git.sd@queasysnail.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Ilya Lesokhin , Aviad Yehezkel , Dave Watson To: Sabrina Dubroca , netdev@vger.kernel.org Return-path: Received: from mail-ve1eur01on0078.outbound.protection.outlook.com ([104.47.1.78]:31451 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726487AbeIESZM (ORCPT ); Wed, 5 Sep 2018 14:25:12 -0400 In-Reply-To: <695fc3449c2ba927e97abd48b452a31ec73d6c61.1536152698.git.sd@queasysnail.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Hi Sabrina, On 9/5/2018 4:21 PM, Sabrina Dubroca wrote: > Fixes: 3c4d7559159b ("tls: kernel TLS support") > Signed-off-by: Sabrina Dubroca > --- > net/tls/tls_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/tls/tls_main.c b/net/tls/tls_main.c > index 180b6640e531..0d432d025471 100644 > --- a/net/tls/tls_main.c > +++ b/net/tls/tls_main.c > @@ -499,7 +499,7 @@ static int do_tls_setsockopt_conf(struct sock *sk, char __user *optval, > goto out; > > err_crypto_info: > - memset(crypto_info, 0, sizeof(*crypto_info)); > + memzero_explicit(crypto_info, sizeof(struct tls12_crypto_info_aes_gcm_128)); Besides the key, there are other (not secret) information in tls12_crypto_info_aes_gcm_128. I'd prefer you do not delete it to enable users to obtain it (using getsockopt) in case we decide to implement a fallback to userspace in the future. Such a fallback must obtain the kernel's iv, and record sequence number. Thanks, Boris.