From: John Fastabend <john.fastabend@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>
Cc: jhs@mojatatu.com, aduyck@mirantis.com, brouer@redhat.com,
davem@davemloft.net, john.r.fastabend@intel.com,
netdev@vger.kernel.org
Subject: Re: [RFC PATCH 02/12] net: sched: free per cpu bstats
Date: Mon, 04 Jan 2016 10:08:05 -0800 [thread overview]
Message-ID: <568AB505.9000508@gmail.com> (raw)
In-Reply-To: <1451928758.8255.76.camel@edumazet-glaptop2.roam.corp.google.com>
On 16-01-04 09:32 AM, Eric Dumazet wrote:
> On Mon, 2016-01-04 at 16:21 +0100, Daniel Borkmann wrote:
>> On 12/30/2015 06:51 PM, John Fastabend wrote:
>>> When a qdisc is using per cpu stats only the bstats are being
>>> freed. This also free's the qstats.
>>>
>>> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
>>
>> Seems like a bug fix, current code seems to free this only in error
>> path in qdisc_create(). Should this go to -net as an individual one?
>
> Absolutely, this is needed in -net as ingress qdisc uses this stuff
> already.
>
>
Yep, I'll push a patch for -net today.
next prev parent reply other threads:[~2016-01-04 18:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-30 17:50 [RFC PATCH 00/12] drop the qdisc lock for pfifo_fast/mq John Fastabend
2015-12-30 17:51 ` [RFC PATCH 01/12] lib: array based lock free queue John Fastabend
2016-01-13 19:28 ` Jesper Dangaard Brouer
2015-12-30 17:51 ` [RFC PATCH 02/12] net: sched: free per cpu bstats John Fastabend
2016-01-04 15:21 ` Daniel Borkmann
2016-01-04 17:32 ` Eric Dumazet
2016-01-04 18:08 ` John Fastabend [this message]
2015-12-30 17:51 ` [RFC PATCH 03/12] net: sched: allow qdiscs to handle locking John Fastabend
2015-12-30 17:52 ` [RFC PATCH 04/12] net: sched: provide per cpu qstat helpers John Fastabend
2015-12-30 17:52 ` [RFC PATCH 05/12] net: sched: per cpu gso handlers John Fastabend
2015-12-30 20:26 ` Jesper Dangaard Brouer
2015-12-30 20:42 ` John Fastabend
2015-12-30 17:53 ` [RFC PATCH 06/12] net: sched: support qdisc_reset on NOLOCK qdisc John Fastabend
2016-01-01 2:30 ` Alexei Starovoitov
2016-01-03 19:37 ` John Fastabend
2016-01-13 16:20 ` David Miller
2016-01-13 18:03 ` John Fastabend
2016-01-15 19:44 ` David Miller
2015-12-30 17:53 ` [RFC PATCH 07/12] net: sched: qdisc_qlen for per cpu logic John Fastabend
2015-12-30 17:53 ` [RFC PATCH 08/12] net: sched: a dflt qdisc may be used with per cpu stats John Fastabend
2015-12-30 17:54 ` [RFC PATCH 09/12] net: sched: pfifo_fast use alf_queue John Fastabend
2016-01-13 16:24 ` David Miller
2016-01-13 18:18 ` John Fastabend
2015-12-30 17:54 ` [RFC PATCH 10/12] net: sched: helper to sum qlen John Fastabend
2015-12-30 17:55 ` [RFC PATCH 11/12] net: sched: add support for TCQ_F_NOLOCK subqueues to sch_mq John Fastabend
2015-12-30 17:55 ` [RFC PATCH 12/12] net: sched: pfifo_fast new option to deque multiple pkts John Fastabend
2015-12-30 18:13 ` John Fastabend
2016-01-06 13:14 ` [RFC PATCH 00/12] drop the qdisc lock for pfifo_fast/mq Jamal Hadi Salim
2016-01-07 23:30 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568AB505.9000508@gmail.com \
--to=john.fastabend@gmail.com \
--cc=aduyck@mirantis.com \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).