From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <alexandre.torgue@st.com>
Subject: Re: [PATCH (net-next.git) 02/18] stmmac: rework DMA bus setting and introduce new platform AXI structure
Date: Tue, 5 Jan 2016 10:32:08 +0100 [thread overview]
Message-ID: <568B8D98.2020102@st.com> (raw)
In-Reply-To: <20160104.222955.94740482244105696.davem@davemloft.net>
On 1/5/2016 4:29 AM, David Miller wrote:
> From: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Date: Mon, 4 Jan 2016 14:06:47 +0100
>
>> @@ -81,7 +81,7 @@ static void stmmac_default_data(struct plat_stmmacenet_data *plat)
>> plat->mdio_bus_data->phy_mask = 0;
>>
>> plat->dma_cfg->pbl = 32;
>> - plat->dma_cfg->burst_len = DMA_AXI_BLEN_256;
>> + /* TODO: AXI */
>>
>> /* Set default value for multicast hash bins */
>> plat->multicast_filter_bins = HASH_TABLE_SIZE;
>> @@ -115,8 +115,8 @@ static int quark_default_data(struct plat_stmmacenet_data *plat,
>> plat->mdio_bus_data->phy_mask = 0;
>>
>> plat->dma_cfg->pbl = 16;
>> - plat->dma_cfg->burst_len = DMA_AXI_BLEN_256;
>> plat->dma_cfg->fixed_burst = 1;
>> + /* AXI (TODO) */
>>
>> /* Set default value for multicast hash bins */
>> plat->multicast_filter_bins = HASH_TABLE_SIZE;
>
> Isn't this going to cause a regression for some things?
trying to rebuild the story of this setting, I understand it
was added to align a configuration so not for fixing some
known problem. I do not see any issue on my side indeed with
the patch applied. My understanding is that, when we adopt "fixed burst
length" it is more safe to use the default burst length instead of
tuning it to the maximum value. I met the same on platform driver
where for performance issue and just in some cases it helped to play
with AXI parameters.
For sure, if somebody has different behavior I can shortly arrange the
code to keep the previous setting or complete the AXI management for PCI
driver (providing a default setup).
Let me know what do you think.
peppe
next prev parent reply other threads:[~2016-01-05 9:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 13:06 [PATCHv2 (net-next.git) 00/18] stmmac: enhance driver performances and update the version Giuseppe Cavallaro
2016-01-04 13:06 ` [PATCH (net-next.git) 01/18] stmmac: share reset function between dwmac100 and dwmac1000 Giuseppe Cavallaro
2016-01-05 3:25 ` David Miller
2016-01-05 9:03 ` Giuseppe CAVALLARO
2016-01-05 18:45 ` David Miller
2016-02-01 15:54 ` Giuseppe CAVALLARO
2016-01-04 13:06 ` [PATCH (net-next.git) 02/18] stmmac: rework DMA bus setting and introduce new platform AXI structure Giuseppe Cavallaro
2016-01-05 3:29 ` David Miller
2016-01-05 9:32 ` Giuseppe CAVALLARO [this message]
2016-01-04 13:06 ` [PATCH (net-next.git) 03/18] stmmac: change descriptor layout Giuseppe Cavallaro
2016-01-04 13:06 ` [PATCH (net-next.git) 04/18] stmmac: remove modulo in stmmac_xmit() Giuseppe Cavallaro
2016-01-05 3:34 ` David Miller
2016-01-05 8:56 ` Giuseppe CAVALLARO
2016-01-04 13:06 ` [PATCH (net-next.git) 05/18] stmmac: add length field to dma data Giuseppe Cavallaro
2016-01-04 13:06 ` [PATCH (net-next.git) 06/18] stmmac: add last_segment " Giuseppe Cavallaro
2016-01-04 13:06 ` [PATCH (net-next.git) 07/18] stmmac: add is_jumbo " Giuseppe Cavallaro
2016-01-04 13:06 ` [PATCH (net-next.git) 08/18] stmmac: merge get_rx_owner into rx_status routine Giuseppe Cavallaro
2016-01-04 13:06 ` [PATCH (net-next.git) 09/18] stmmac: optimize tx desc management Giuseppe Cavallaro
2016-01-05 3:39 ` David Miller
2016-01-05 8:57 ` Giuseppe CAVALLARO
2016-01-04 13:06 ` [PATCH (net-next.git) 10/18] stmmac: optimize tx clean function Giuseppe Cavallaro
2016-01-04 13:06 ` [PATCH (net-next.git) 11/18] stmmac: set dirty index out of the loop Giuseppe Cavallaro
2016-01-04 13:06 ` [PATCH (net-next.git) 12/18] stmmac: first frame prep at the end of xmit routine Giuseppe Cavallaro
2016-01-04 13:06 ` [PATCH (net-next.git) 13/18] stmmac: perf, remove modulo in stmmac_rx() Giuseppe Cavallaro
2016-01-04 13:06 ` [PATCH (net-next.git) 14/18] stmmac: do not poll phy handler when attach a switch Giuseppe Cavallaro
2016-01-04 13:07 ` [PATCH (net-next.git) 15/18] stmmac: fix phy init when attached to a phy Giuseppe Cavallaro
2016-01-04 13:07 ` [PATCHv2 (net-next.git) 16/18] stmmac: do not perform zero-copy for rx frames Giuseppe Cavallaro
2016-01-04 13:07 ` [PATCH (net-next.git) 17/18] stmmac: tune rx copy via threshold Giuseppe Cavallaro
2016-01-04 13:07 ` [PATCH (net-next.git) 18/18] stmmac: update version to Oct_2015 Giuseppe Cavallaro
-- strict thread matches above, loose matches on Subject: below --
2015-12-09 8:37 [PATCH (net-next.git) 00/18] stmmac: enhance driver performances and update the version Giuseppe Cavallaro
2015-12-09 8:37 ` [PATCH (net-next.git) 02/18] stmmac: rework DMA bus setting and introduce new platform AXI structure Giuseppe Cavallaro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568B8D98.2020102@st.com \
--to=peppe.cavallaro@st.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).