From: John Fastabend <john.fastabend@gmail.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: netdev@vger.kernel.org, alexei.starovoitov@gmail.com,
davem@davemloft.net
Subject: Re: [PATCH] net: pktgen: support injecting packets for qdisc testing
Date: Fri, 08 Jan 2016 07:24:08 -0800 [thread overview]
Message-ID: <568FD498.5030401@gmail.com> (raw)
In-Reply-To: <568FC9F8.8040201@mojatatu.com>
On 16-01-08 06:38 AM, Jamal Hadi Salim wrote:
> On 16-01-07 09:28 PM, John Fastabend wrote:
>>
>> Hi Jamal,
>>
>> per your comment about using pktgen to test qdiscs here is the
>> patch I've been using most the day which has been working well.
>> I'm guessing this is more or less what you had in mind.
>>
>
> I have attached the one i used over the holidays - see if there are
> any differences(sorry dont have much time right now).
>
> cheers,
> jamal
Close except I don't back off the qdisc when I get
xmit_{drop|cn|policed} return codes because I'm trying to
stress the qdisc.
Also I don't see the point to doing the skb_get_tx_queue and
txq_trans_update() this should be called by dev_queue_xmit
anyways.
If its all the same to you I would just assume have my version in
pktgen and later if its useful for you add an option to back-off
when the qdisc throws an error.
Thanks,
John
next prev parent reply other threads:[~2016-01-08 15:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 2:09 [PATCH] net: pktgen: support injecting packets for qdisc testing John Fastabend
2016-01-08 2:28 ` John Fastabend
2016-01-08 14:38 ` Jamal Hadi Salim
2016-01-08 15:24 ` John Fastabend [this message]
2016-01-09 0:41 ` John Fastabend
2016-01-10 14:09 ` Jamal Hadi Salim
2016-01-11 5:21 ` John Fastabend
2016-01-08 15:28 ` John Fastabend
2016-01-08 15:38 ` John Fastabend
2016-01-08 21:36 ` Eric Dumazet
2016-01-08 21:55 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568FD498.5030401@gmail.com \
--to=john.fastabend@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).