From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [PATCH] net: pktgen: support injecting packets for qdisc testing Date: Fri, 08 Jan 2016 07:24:08 -0800 Message-ID: <568FD498.5030401@gmail.com> References: <20160108020908.5940.89612.stgit@john-Precision-Tower-5810> <568F1EE2.7020107@gmail.com> <568FC9F8.8040201@mojatatu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, alexei.starovoitov@gmail.com, davem@davemloft.net To: Jamal Hadi Salim Return-path: Received: from mail-pf0-f171.google.com ([209.85.192.171]:35921 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755119AbcAHPYU (ORCPT ); Fri, 8 Jan 2016 10:24:20 -0500 Received: by mail-pf0-f171.google.com with SMTP id n128so11080933pfn.3 for ; Fri, 08 Jan 2016 07:24:19 -0800 (PST) In-Reply-To: <568FC9F8.8040201@mojatatu.com> Sender: netdev-owner@vger.kernel.org List-ID: On 16-01-08 06:38 AM, Jamal Hadi Salim wrote: > On 16-01-07 09:28 PM, John Fastabend wrote: >> >> Hi Jamal, >> >> per your comment about using pktgen to test qdiscs here is the >> patch I've been using most the day which has been working well. >> I'm guessing this is more or less what you had in mind. >> > > I have attached the one i used over the holidays - see if there are > any differences(sorry dont have much time right now). > > cheers, > jamal Close except I don't back off the qdisc when I get xmit_{drop|cn|policed} return codes because I'm trying to stress the qdisc. Also I don't see the point to doing the skb_get_tx_queue and txq_trans_update() this should be called by dev_queue_xmit anyways. If its all the same to you I would just assume have my version in pktgen and later if its useful for you add an option to back-off when the qdisc throws an error. Thanks, John