From: Jacob Keller <jacob.e.keller@intel.com>
To: <edward.cree@amd.com>, <linux-net-drivers@amd.com>,
<davem@davemloft.net>, <kuba@kernel.org>, <edumazet@google.com>,
<pabeni@redhat.com>
Cc: Edward Cree <ecree.xilinx@gmail.com>, <netdev@vger.kernel.org>,
<habetsm.xilinx@gmail.com>
Subject: Re: [PATCH v4 net-next 0/7] sfc: per-queue stats
Date: Fri, 4 Oct 2024 15:37:17 -0700 [thread overview]
Message-ID: <568e83fb-ba49-4998-9245-7353ae2cb563@intel.com> (raw)
In-Reply-To: <cover.1727703521.git.ecree.xilinx@gmail.com>
On 9/30/2024 6:52 AM, edward.cree@amd.com wrote:
> From: Edward Cree <ecree.xilinx@gmail.com>
>
> This series implements the netdev_stat_ops interface for per-queue
> statistics in the sfc driver, partly using existing counters that
> were originally added for ethtool -S output.
>
> Changed in v4:
> * remove RFC tags
>
> Changed in v3:
> * make TX stats count completions rather than enqueues
> * add new patch #4 to account for XDP TX separately from netdev
> traffic and include it in base_stats
> * move the tx_queue->old_* members out of the fastpath cachelines
> * note on patch #6 that our hw_gso stats still count enqueues
> * RFC since net-next is closed right now
>
> Changed in v2:
> * exclude (dedicated) XDP TXQ stats from per-queue TX stats
> * explain patch #3 better
>
> Edward Cree (7):
> sfc: remove obsolete counters from struct efx_channel
> sfc: implement basic per-queue stats
> sfc: add n_rx_overlength to ethtool stats
> sfc: account XDP TXes in netdev base stats
> sfc: implement per-queue rx drop and overrun stats
> sfc: implement per-queue TSO (hw_gso) stats
> sfc: add per-queue RX bytes stats
>
The whole series looks good to me, thanks!
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
next prev parent reply other threads:[~2024-10-04 22:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 13:52 [PATCH v4 net-next 0/7] sfc: per-queue stats edward.cree
2024-09-30 13:52 ` [PATCH v4 net-next 1/7] sfc: remove obsolete counters from struct efx_channel edward.cree
2024-09-30 13:52 ` [PATCH v4 net-next 2/7] sfc: implement basic per-queue stats edward.cree
2024-10-04 22:36 ` Jacob Keller
2024-09-30 13:52 ` [PATCH v4 net-next 3/7] sfc: add n_rx_overlength to ethtool stats edward.cree
2024-09-30 13:52 ` [PATCH v4 net-next 4/7] sfc: account XDP TXes in netdev base stats edward.cree
2024-10-04 22:36 ` Jacob Keller
2024-09-30 13:52 ` [PATCH v4 net-next 5/7] sfc: implement per-queue rx drop and overrun stats edward.cree
2024-09-30 13:52 ` [PATCH v4 net-next 6/7] sfc: implement per-queue TSO (hw_gso) stats edward.cree
2024-09-30 13:52 ` [PATCH v4 net-next 7/7] sfc: add per-queue RX bytes stats edward.cree
2024-10-04 22:37 ` Jacob Keller [this message]
2024-10-06 15:10 ` [PATCH v4 net-next 0/7] sfc: per-queue stats patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568e83fb-ba49-4998-9245-7353ae2cb563@intel.com \
--to=jacob.e.keller@intel.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=edward.cree@amd.com \
--cc=habetsm.xilinx@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).