* [PATCH] net: phy: Add support for SMSC LAN8740 PHY
@ 2016-01-09 0:57 Joshua Henderson
2016-01-09 1:36 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: Joshua Henderson @ 2016-01-09 0:57 UTC (permalink / raw)
To: linux-kernel; +Cc: Joshua Henderson, Florian Fainelli, netdev
LAN8740 has a different phy_id than LAN8710/LAN8720.
Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
---
drivers/net/phy/smsc.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c
index dc2da87..34021a5 100644
--- a/drivers/net/phy/smsc.c
+++ b/drivers/net/phy/smsc.c
@@ -264,6 +264,29 @@ static struct phy_driver smsc_phy_driver[] = {
.resume = genphy_resume,
.driver = { .owner = THIS_MODULE, }
+}, {
+ .phy_id = 0x0007c110,
+ .phy_id_mask = 0xfffffff0,
+ .name = "SMSC LAN8740",
+
+ .features = (PHY_BASIC_FEATURES | SUPPORTED_Pause
+ | SUPPORTED_Asym_Pause),
+ .flags = PHY_HAS_INTERRUPT | PHY_HAS_MAGICANEG,
+
+ /* basic functions */
+ .config_aneg = genphy_config_aneg,
+ .read_status = lan87xx_read_status,
+ .config_init = smsc_phy_config_init,
+ .soft_reset = smsc_phy_reset,
+
+ /* IRQ related */
+ .ack_interrupt = smsc_phy_ack_interrupt,
+ .config_intr = smsc_phy_config_intr,
+
+ .suspend = genphy_suspend,
+ .resume = genphy_resume,
+
+ .driver = { .owner = THIS_MODULE, }
} };
module_phy_driver(smsc_phy_driver);
@@ -278,6 +301,7 @@ static struct mdio_device_id __maybe_unused smsc_tbl[] = {
{ 0x0007c0c0, 0xfffffff0 },
{ 0x0007c0d0, 0xfffffff0 },
{ 0x0007c0f0, 0xfffffff0 },
+ { 0x0007c110, 0xfffffff0 },
{ }
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: Add support for SMSC LAN8740 PHY
2016-01-09 0:57 [PATCH] net: phy: Add support for SMSC LAN8740 PHY Joshua Henderson
@ 2016-01-09 1:36 ` Andrew Lunn
2016-01-09 11:43 ` Joshua Henderson
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Lunn @ 2016-01-09 1:36 UTC (permalink / raw)
To: Joshua Henderson; +Cc: linux-kernel, Florian Fainelli, netdev
On Fri, Jan 08, 2016 at 05:57:20PM -0700, Joshua Henderson wrote:
> LAN8740 has a different phy_id than LAN8710/LAN8720.
>
> Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
> ---
> drivers/net/phy/smsc.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c
> index dc2da87..34021a5 100644
> --- a/drivers/net/phy/smsc.c
> +++ b/drivers/net/phy/smsc.c
> @@ -264,6 +264,29 @@ static struct phy_driver smsc_phy_driver[] = {
> .resume = genphy_resume,
>
> .driver = { .owner = THIS_MODULE, }
> +}, {
> + .phy_id = 0x0007c110,
> + .phy_id_mask = 0xfffffff0,
> + .name = "SMSC LAN8740",
> +
> + .features = (PHY_BASIC_FEATURES | SUPPORTED_Pause
> + | SUPPORTED_Asym_Pause),
> + .flags = PHY_HAS_INTERRUPT | PHY_HAS_MAGICANEG,
> +
> + /* basic functions */
> + .config_aneg = genphy_config_aneg,
> + .read_status = lan87xx_read_status,
> + .config_init = smsc_phy_config_init,
> + .soft_reset = smsc_phy_reset,
> +
> + /* IRQ related */
> + .ack_interrupt = smsc_phy_ack_interrupt,
> + .config_intr = smsc_phy_config_intr,
> +
> + .suspend = genphy_suspend,
> + .resume = genphy_resume,
> +
> + .driver = { .owner = THIS_MODULE, }
> } };
Hi Joshua
You should remove this .driver line. The core sets it now.
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: Add support for SMSC LAN8740 PHY
2016-01-09 1:36 ` Andrew Lunn
@ 2016-01-09 11:43 ` Joshua Henderson
0 siblings, 0 replies; 3+ messages in thread
From: Joshua Henderson @ 2016-01-09 11:43 UTC (permalink / raw)
To: Andrew Lunn; +Cc: linux-kernel, Florian Fainelli, netdev
On 1/8/2016 6:36 PM, Andrew Lunn wrote:
> On Fri, Jan 08, 2016 at 05:57:20PM -0700, Joshua Henderson wrote:
>> LAN8740 has a different phy_id than LAN8710/LAN8720.
>>
>> Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
>> ---
>> drivers/net/phy/smsc.c | 24 ++++++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>>
>> diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c
>> index dc2da87..34021a5 100644
>> --- a/drivers/net/phy/smsc.c
>> +++ b/drivers/net/phy/smsc.c
>> @@ -264,6 +264,29 @@ static struct phy_driver smsc_phy_driver[] = {
>> .resume = genphy_resume,
>>
>> .driver = { .owner = THIS_MODULE, }
>> +}, {
>> + .phy_id = 0x0007c110,
>> + .phy_id_mask = 0xfffffff0,
>> + .name = "SMSC LAN8740",
>> +
>> + .features = (PHY_BASIC_FEATURES | SUPPORTED_Pause
>> + | SUPPORTED_Asym_Pause),
>> + .flags = PHY_HAS_INTERRUPT | PHY_HAS_MAGICANEG,
>> +
>> + /* basic functions */
>> + .config_aneg = genphy_config_aneg,
>> + .read_status = lan87xx_read_status,
>> + .config_init = smsc_phy_config_init,
>> + .soft_reset = smsc_phy_reset,
>> +
>> + /* IRQ related */
>> + .ack_interrupt = smsc_phy_ack_interrupt,
>> + .config_intr = smsc_phy_config_intr,
>> +
>> + .suspend = genphy_suspend,
>> + .resume = genphy_resume,
>> +
>> + .driver = { .owner = THIS_MODULE, }
>> } };
>
> Hi Joshua
>
> You should remove this .driver line. The core sets it now.
>
> Andrew
>
Got it. I'll apply against net-next.
Thanks,
Josh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-09 11:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-09 0:57 [PATCH] net: phy: Add support for SMSC LAN8740 PHY Joshua Henderson
2016-01-09 1:36 ` Andrew Lunn
2016-01-09 11:43 ` Joshua Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).