From: Guenter Roeck <linux@roeck-us.net>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe function
Date: Sun, 10 Jan 2016 08:22:17 -0800 [thread overview]
Message-ID: <56928539.1060009@roeck-us.net> (raw)
In-Reply-To: <20160110154945.GD22229@lunn.ch>
On 01/10/2016 07:49 AM, Andrew Lunn wrote:
>> How about those ?
>>
>> drivers/net/ethernet/freescale/ucc_geth.c: In function 'uec_configure_serdes':
>> drivers/net/ethernet/freescale/ucc_geth.c:1719:20: error: 'struct phy_device' has no member named 'dev'
>>
>> drivers/net/ethernet/freescale/fs_enet/mac-fec.c: In function 'stop':
>> drivers/net/ethernet/freescale/fs_enet/mac-fec.c:366:36: error: 'struct phy_device' has no member named 'bus'
>
> Not seen fixes for those, nor error reports either.
>
Ok, I'll see if I can fix those.
Also:
drivers/net/ethernet/amd/au1000_eth.c: /* WARNING: bus->phy_map[phy_addr].attached_dev == dev does
[ no idea what to do with that comment ]
drivers/net/ethernet/broadcom/sb1250-mac.c: phy_dev = sc->mii_bus->phy_map[i];
[ can use phy_find_first ]
drivers/staging/netlogic/xlr_net.c: struct phy_device *phydev = priv->mii_bus->phy_map[priv->phy_addr];
[ several ]
> I think the next time i do something like this, i'm going to ask you
> to run some built tests for me! You seem to have better coverage than
> 0-day.
>
Sure, no problem.
Guenter
next prev parent reply other threads:[~2016-01-10 16:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 16:37 [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe function Guenter Roeck
2016-01-09 16:37 ` [PATCH -next 2/2] net: bfin_mac: Fix build error due to missed API change Guenter Roeck
2016-01-09 16:58 ` [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe function Andrew Lunn
2016-01-09 18:10 ` Guenter Roeck
2016-01-09 20:52 ` Andrew Lunn
2016-01-10 15:16 ` Guenter Roeck
2016-01-10 15:49 ` Andrew Lunn
2016-01-10 16:22 ` Guenter Roeck [this message]
2016-01-10 17:21 ` Andrew Lunn
2016-01-10 20:10 ` Guenter Roeck
2016-01-10 23:58 ` Andrew Lunn
2016-01-11 8:43 ` Sudip Mukherjee
2016-01-11 16:23 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56928539.1060009@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).