From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Manjeet Pawar <manjeet.p@samsung.com>, <davem@davemloft.net>,
<schmitzmic@gmail.com>, <geert@linux-m68k.org>,
<nico@fluxnic.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <akhilesh.k@samsung.com>
Cc: <pankaj.m@samsung.com>
Subject: Re: [PATCH 1/1] smsc: Enabling SMSC LAN911 driver for ARM64 as well.
Date: Mon, 11 Jan 2016 10:16:38 -0500 [thread overview]
Message-ID: <5693C756.8010108@windriver.com> (raw)
In-Reply-To: <1452502945-27765-1-git-send-email-manjeet.p@samsung.com>
On 2016-01-11 04:02 AM, Manjeet Pawar wrote:
> This patch enable network driver support for ARM64
Your commit log only repeats what is obvious from the one line
change itself. It might be nice to indicate what platform it
was validated on, what tests were run and what features of the
driver were exercised (multicast, netpoll, ...)
Imagine if I sent you a similar patch where I added MIPS and
said nothing more than "enable network driver support for MIPS"
and Cc'd you expecting you to comment on whether it was OK.
Thanks,
Paul.
next prev parent reply other threads:[~2016-01-11 15:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 9:02 [PATCH 1/1] smsc: Enabling SMSC LAN911 driver for ARM64 as well Manjeet Pawar
2016-01-11 14:10 ` Sergei Shtylyov
2016-01-11 15:16 ` Paul Gortmaker [this message]
2016-01-11 22:32 ` kbuild test robot
2016-01-11 22:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5693C756.8010108@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=akhilesh.k@samsung.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manjeet.p@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=pankaj.m@samsung.com \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).