From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Tom Herbert <tom@herbertland.com>,
davem@davemloft.net, netdev@vger.kernel.org
Cc: jackm@dev.mellanox.co.il, kernel-team@fb.com
Subject: Re: [PATCH net-next] net: Fix typo in netdev_intersect_features
Date: Mon, 11 Jan 2016 21:24:41 +0300 [thread overview]
Message-ID: <5693F369.6020600@cogentembedded.com> (raw)
In-Reply-To: <1452536350-432426-1-git-send-email-tom@herbertland.com>
Hello.
On 01/11/2016 09:19 PM, Tom Herbert wrote:
> Obviously need to 'or in NETIF_F_IP_CSUM and NETIF_F_IPV6_CSUM.
>
> Fixes: c8cd0989bd151f ("net: Eliminate NETIF_F_GEN_CSUM and NETIF_F_V[46]_CSUM")
> Reported-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
> Signed-off-by: Tom Herbert <tom@herbertland.com>
> ---
> include/linux/netdevice.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 8d8e5ca..a951274 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -3871,9 +3871,9 @@ static inline netdev_features_t netdev_intersect_features(netdev_features_t f1,
> {
> if ((f1 ^ f2) & NETIF_F_HW_CSUM) {
> if (f1 & NETIF_F_HW_CSUM)
> - f1 |= (NETIF_F_IP_CSUM|NETIF_F_IP_CSUM);
> + f1 |= (NETIF_F_IP_CSUM|NETIF_F_IPV6_CSUM);
> else
> - f2 |= (NETIF_F_IP_CSUM|NETIF_F_IP_CSUM);
> + f2 |= (NETIF_F_IP_CSUM|NETIF_F_IPV6_CSUM);
The general kernel coding style is to have the operators surrounded by spaces.
[...]
WBR, Sergei
next prev parent reply other threads:[~2016-01-11 18:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 18:19 [PATCH net-next] net: Fix typo in netdev_intersect_features Tom Herbert
2016-01-11 18:24 ` Sergei Shtylyov [this message]
2016-01-12 4:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5693F369.6020600@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=jackm@dev.mellanox.co.il \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).