From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Damien Riegel <damien.riegel@savoirfairelinux.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-can@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Wolfgang Grandegger <wg@grandegger.com>,
kernel@savoirfairelinux.com
Subject: Re: [PATCH v2 0/3] can: sja1000: support for technologic version
Date: Tue, 12 Jan 2016 08:56:48 +0100 [thread overview]
Message-ID: <5694B1C0.2070702@pengutronix.de> (raw)
In-Reply-To: <20160111165807.GA7116@localhost>
[-- Attachment #1: Type: text/plain, Size: 1355 bytes --]
On 01/11/2016 05:58 PM, Damien Riegel wrote:
> Hi Marc,
>
> On Thu, Dec 24, 2015 at 12:42:50PM -0500, Damien Riegel wrote:
>> This patchset introduces support for the technologic version of the
>> SJA1000. Access to IP's registers are proxied through a window,
>> requiring two bus accesses to read or write a register. These accesses
>> must be protected by a spinlock to prevent race conditions. Currently,
>> there is no easy way to allocate and initialize this spinlock.
>>
>> SJA1000 already provides a way to allocate private data, but
>> sja1000_platform.c makes no use of it.
>>
>> Patch 1 adds the capability to allocate and initialize private data on a
>> per-compatible basis in sja1000_platform.c.
>>
>> Patch 2 updates device tree documentation to add the technologic
>> version.
>>
>> Patch 3 updates the driver to implement the technologic version
>>
>
> Did you have a chance to take a look at this patchset? I would
> appreciate your feedback, especially on the first patch.
Done. 2/3 is ok. For the others see my comments.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
prev parent reply other threads:[~2016-01-12 7:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 17:42 [PATCH v2 0/3] can: sja1000: support for technologic version Damien Riegel
2015-12-24 17:42 ` [PATCH v2 1/3] can: sja1000: of: add per-compatible init hook Damien Riegel
2016-01-12 7:52 ` Marc Kleine-Budde
2016-01-12 15:53 ` Damien Riegel
2016-01-12 16:24 ` Marc Kleine-Budde
2015-12-24 17:42 ` [PATCH v2 2/3] can: sja1000: add documentation for Technologic Systems version Damien Riegel
2015-12-24 17:42 ` [PATCH v2 3/3] can: sja1000: of: add compatibility with " Damien Riegel
2016-01-12 7:55 ` Marc Kleine-Budde
2016-01-12 15:51 ` Damien Riegel
2016-01-11 16:58 ` [PATCH v2 0/3] can: sja1000: support for technologic version Damien Riegel
2016-01-12 7:56 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5694B1C0.2070702@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=damien.riegel@savoirfairelinux.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@savoirfairelinux.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).