netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Fastabend <john.fastabend@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, bogdan.hamciuc@freescale.com
Subject: Re: [PATCH] net: pktgen: fix null ptr deref in skb allocation
Date: Tue, 12 Jan 2016 09:32:44 -0800	[thread overview]
Message-ID: <569538BC.7090202@gmail.com> (raw)
In-Reply-To: <20160111.174031.1199997012538036511.davem@davemloft.net>

On 16-01-11 02:40 PM, David Miller wrote:
> From: John Fastabend <john.fastabend@gmail.com>
> Date: Sun, 10 Jan 2016 21:38:44 -0800
> 
>> Fix possible null pointer dereference that may occur when calling
>> skb_reserve() on a null skb.
>>
>> Fixes: 879c7220e82 ("net: pktgen: Observe needed_headroom of the device")
>> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
> 
> I don't know how I missed that during review :-/

Well once you get pktgen running fast enough to get allocation
failures the occasional system halts are pretty hard to miss :)

> 
> Applied and queued up for -stable, thanks!
> 

      reply	other threads:[~2016-01-12 17:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-11  5:38 [PATCH] net: pktgen: fix null ptr deref in skb allocation John Fastabend
2016-01-11 22:40 ` David Miller
2016-01-12 17:32   ` John Fastabend [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569538BC.7090202@gmail.com \
    --to=john.fastabend@gmail.com \
    --cc=bogdan.hamciuc@freescale.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).