netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yuki Machida <machida.yuki@jp.fujitsu.com>
To: YOSHIFUJI Hideaki <hideaki.yoshifuji@miraclelinux.com>,
	netdev@vger.kernel.org
Cc: Hangbin Liu <liuhangbin@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"YOSHIFUJI Hideaki (USAGI Project)" <yoshfuji@linux-ipv6.org>
Subject: Re: [PATCH 1/1] net/ipv6: add sysctl option accept_ra_min_hop_limit
Date: Fri, 15 Jan 2016 18:25:04 +0900	[thread overview]
Message-ID: <5698BAF0.7060709@jp.fujitsu.com> (raw)
In-Reply-To: <568B9836.1000202@miraclelinux.com>

Hi, Yoshifuji-san

It is currently under investigation.
It takes still time.

Futher comment below.

On 2016年01月05日 19:17, YOSHIFUJI Hideaki wrote:
> Hi, Machida-san.
> 
> Yuki Machida wrote:
>> Please apply the following patch to v4.1.x.
>>
>> By ommit 6fd99094de2b ("ipv6: Don't reduce hop limit for an interface")
> 
> s/ommit/commit/
I will correct this typo.

> 
> Futher comment below.
> 
> :
>> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
>> Acked-by: YOSHIFUJI Hideaki <hideaki.yoshifuji@miraclelinux.com>
>> Signed-off-by: David S. Miller <davem@davemloft.net>
>> ---
>>   Documentation/networking/ip-sysctl.txt |  8 ++++++++
>>   include/linux/ipv6.h                   |  1 +
>>   include/uapi/linux/ipv6.h              |  1 +
>>   net/ipv6/addrconf.c                    | 10 ++++++++++
>>   net/ipv6/ndisc.c                       | 16 +++++++---------
>>   5 files changed, 27 insertions(+), 9 deletions(-)
>>
>> diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
>> index 071fb18..07fad3d 100644
> :
>> --- a/include/uapi/linux/ipv6.h
>> +++ b/include/uapi/linux/ipv6.h
>> @@ -171,6 +171,7 @@ enum {
>>   	DEVCONF_USE_OPTIMISTIC,
>>   	DEVCONF_ACCEPT_RA_MTU,
>>   	DEVCONF_STABLE_SECRET,
> 
> You have to add a hole for DEVCONF_USE_OIF_ADDRS_ONLY.

For addition a hole of DEVCONF_USE_OIF_ADDRS_ONLY,
It needs following two patches.
commit 9131f3de24db4dc12199aede7d931e6703e97f3b
commit 3985e8a3611a93bb36789f65db862e5700aab65e

When It apply two patches to 4.1.15,
It doesn't conform to RFC 2460 and RFC 4443.
(I used IPv6 Ready Logo Core Conformance Test.)
I am looking for a patch for fix.

> --yoshfuji
> 
>> +	DEVCONF_ACCEPT_RA_MIN_HOP_LIMIT,
>>   	DEVCONF_MAX
>>   };
>>   
> 

  parent reply	other threads:[~2016-01-15  9:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-04  8:37 [PATCH 1/1] net/ipv6: add sysctl option accept_ra_min_hop_limit Yuki Machida
2016-01-05 10:17 ` YOSHIFUJI Hideaki
2016-01-06  2:23   ` Yuki Machida
2016-01-15  9:25   ` Yuki Machida [this message]
2016-01-18  8:33     ` YOSHIFUJI Hideaki
2016-02-02  8:49       ` Yuki Machida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5698BAF0.7060709@jp.fujitsu.com \
    --to=machida.yuki@jp.fujitsu.com \
    --cc=davem@davemloft.net \
    --cc=hideaki.yoshifuji@miraclelinux.com \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).