From: Florian Fainelli <f.fainelli@gmail.com>
To: Woojung.Huh@microchip.com, davem@davemloft.net
Cc: netdev@vger.kernel.org, andrew@lunn.ch,
sergei.shtylyov@cogentembedded.com
Subject: Re: [PATCH net 0/3] net: phy: Finally fix PHY_IGNORE_INTERRUPTS
Date: Wed, 20 Jan 2016 13:29:50 -0800 [thread overview]
Message-ID: <569FFC4E.20803@gmail.com> (raw)
In-Reply-To: <9235D6609DB808459E95D78E17F2E43D40499B30@CHN-SV-EXMX02.mchp-main.com>
Le 20/01/2016 13:20, Woojung.Huh@microchip.com a écrit :
>>> Targetting the "net" tree since these are bugfixes, but I would like
>>> Woojun and Andrew to take a look and test that on their respective
>>> HW setups as well.
>>
>> Ok I'll wait for Woojun and Andrew to give feedback.
>
> This patch fixes periodic phy read_status access when phy is configured as PHY_IGNORE_INTERRUPTS.
Great, thanks for the feedback!
> Tested and confirmed with LAN78xx USB-to-Ethernet driver except following checkpatch.pl warnings.
>
> WARNING: line over 80 characters
> #54: FILE: drivers/net/phy/phy.c:1008:
> + queue_delayed_work(system_power_efficient_wq, &phydev->state_queue,
This one is definitively added by the patch
>
> WARNING: Comparisons should place the constant on the right side of the test
> #68: FILE: drivers/net/phy/phy.c:714:
> + if (PHY_HALTED != phydev->state &&
>
This one is an existing warning.
David, let me know if you consider the over 80 columns issue worth a
resubmission or not, either way is fine with me.
Thanks!
--
Florian
next prev parent reply other threads:[~2016-01-20 21:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 3:33 [PATCH net 0/3] net: phy: Finally fix PHY_IGNORE_INTERRUPTS Florian Fainelli
2016-01-19 3:33 ` [PATCH net 1/3] net: phy: Avoid polling PHY with PHY_IGNORE_INTERRUPTS Florian Fainelli
2016-01-19 3:33 ` [PATCH net 2/3] net: phy: Fix phy_mac_interrupt() Florian Fainelli
2016-01-19 3:33 ` [PATCH net 3/3] net: bcmgenet: Properly configure PHY to ignore interrupt Florian Fainelli
2016-01-19 19:33 ` [PATCH net 0/3] net: phy: Finally fix PHY_IGNORE_INTERRUPTS David Miller
2016-01-20 21:20 ` Woojung.Huh
2016-01-20 21:29 ` Florian Fainelli [this message]
2016-01-20 22:20 ` Woojung.Huh
2016-01-21 0:59 ` Woojung.Huh
2016-01-21 2:58 ` David Miller
2016-01-21 6:32 ` Florian Fainelli
2016-01-21 18:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569FFC4E.20803@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).