* [PATCH] ipv4+ipv6: Make INET*_ESP select CRYPTO_ECHAINIV
@ 2016-01-23 13:30 Thomas Egerer
2016-01-25 10:26 ` Herbert Xu
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Egerer @ 2016-01-23 13:30 UTC (permalink / raw)
To: netdev
The ESP algorithms using CBC mode require echainiv. Hence INET*_ESP have
to select CRYPTO_ECHAINIV in order to work properly. This solves the
issues caused by a misconfiguration as described in [1].
The original approach, patching crypto/Kconfig was turned down by
Herbert Xu [2].
[1] https://lists.strongswan.org/pipermail/users/2015-December/009074.html
[2] http://marc.info/?l=linux-crypto-vger&m=145224655809562&w=2
Signed-off-by: Thomas Egerer <hakke_007@gmx.de>
---
net/ipv4/Kconfig | 1 +
net/ipv6/Kconfig | 1 +
2 files changed, 2 insertions(+)
diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index c229205..7758247 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -353,6 +353,7 @@ config INET_ESP
select CRYPTO_CBC
select CRYPTO_SHA1
select CRYPTO_DES
+ select CRYPTO_ECHAINIV
---help---
Support for IPsec ESP.
diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig
index bb7dabe..40c8975 100644
--- a/net/ipv6/Kconfig
+++ b/net/ipv6/Kconfig
@@ -69,6 +69,7 @@ config INET6_ESP
select CRYPTO_CBC
select CRYPTO_SHA1
select CRYPTO_DES
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ipv4+ipv6: Make INET*_ESP select CRYPTO_ECHAINIV
2016-01-23 13:30 [PATCH] ipv4+ipv6: Make INET*_ESP select CRYPTO_ECHAINIV Thomas Egerer
@ 2016-01-25 10:26 ` Herbert Xu
2016-01-25 11:57 ` Thomas Egerer
2016-01-25 11:58 ` Thomas Egerer
0 siblings, 2 replies; 6+ messages in thread
From: Herbert Xu @ 2016-01-25 10:26 UTC (permalink / raw)
To: Thomas Egerer; +Cc: netdev
Thomas Egerer <hakke_007@gmx.de> wrote:
> The ESP algorithms using CBC mode require echainiv. Hence INET*_ESP have
> to select CRYPTO_ECHAINIV in order to work properly. This solves the
> issues caused by a misconfiguration as described in [1].
> The original approach, patching crypto/Kconfig was turned down by
> Herbert Xu [2].
>
> [1] https://lists.strongswan.org/pipermail/users/2015-December/009074.html
> [2] http://marc.info/?l=linux-crypto-vger&m=145224655809562&w=2
>
> Signed-off-by: Thomas Egerer <hakke_007@gmx.de>
> ---
> net/ipv4/Kconfig | 1 +
> net/ipv6/Kconfig | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
> index c229205..7758247 100644
> --- a/net/ipv4/Kconfig
> +++ b/net/ipv4/Kconfig
> @@ -353,6 +353,7 @@ config INET_ESP
> select CRYPTO_CBC
> select CRYPTO_SHA1
> select CRYPTO_DES
> + select CRYPTO_ECHAINIV
> ---help---
> Support for IPsec ESP.
>
> diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig
> index bb7dabe..40c8975 100644
> --- a/net/ipv6/Kconfig
> +++ b/net/ipv6/Kconfig
> @@ -69,6 +69,7 @@ config INET6_ESP
> select CRYPTO_CBC
> select CRYPTO_SHA1
> select CRYPTO_DES
Your patch seems to be missing a few lines at the end.
Otherwise it looks good to me.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ipv4+ipv6: Make INET*_ESP select CRYPTO_ECHAINIV
2016-01-25 10:26 ` Herbert Xu
@ 2016-01-25 11:57 ` Thomas Egerer
2016-01-25 11:58 ` Thomas Egerer
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Egerer @ 2016-01-25 11:57 UTC (permalink / raw)
To: Herbert Xu; +Cc: netdev
On 01/25/2016 11:26 AM, Herbert Xu wrote:
> Thomas Egerer <hakke_007@gmx.de> wrote:
>> The ESP algorithms using CBC mode require echainiv. Hence INET*_ESP have
>> to select CRYPTO_ECHAINIV in order to work properly. This solves the
>> issues caused by a misconfiguration as described in [1].
>> The original approach, patching crypto/Kconfig was turned down by
>> Herbert Xu [2].
>>
>> [1] https://lists.strongswan.org/pipermail/users/2015-December/009074.html
>> [2] http://marc.info/?l=linux-crypto-vger&m=145224655809562&w=2
>>
>> Signed-off-by: Thomas Egerer <hakke_007@gmx.de>
>> ---
>> net/ipv4/Kconfig | 1 +
>> net/ipv6/Kconfig | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
>> index c229205..7758247 100644
>> --- a/net/ipv4/Kconfig
>> +++ b/net/ipv4/Kconfig
>> @@ -353,6 +353,7 @@ config INET_ESP
>> select CRYPTO_CBC
>> select CRYPTO_SHA1
>> select CRYPTO_DES
>> + select CRYPTO_ECHAINIV
>> ---help---
>> Support for IPsec ESP.
>>
>> diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig
>> index bb7dabe..40c8975 100644
>> --- a/net/ipv6/Kconfig
>> +++ b/net/ipv6/Kconfig
>> @@ -69,6 +69,7 @@ config INET6_ESP
>> select CRYPTO_CBC
>> select CRYPTO_SHA1
>> select CRYPTO_DES
>
> Your patch seems to be missing a few lines at the end.
That's odd, yet the my outbox contains a truncated mail, too.
Sorry, will resend the patch in a jiff.
Thomas
> Otherwise it looks good to me.
>
> Cheers,
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ipv4+ipv6: Make INET*_ESP select CRYPTO_ECHAINIV
2016-01-25 10:26 ` Herbert Xu
2016-01-25 11:57 ` Thomas Egerer
@ 2016-01-25 11:58 ` Thomas Egerer
2016-01-25 13:56 ` Herbert Xu
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Egerer @ 2016-01-25 11:58 UTC (permalink / raw)
To: Herbert Xu; +Cc: netdev
The ESP algorithms using CBC mode require echainiv. Hence INET*_ESP have
to select CRYPTO_ECHAINIV in order to work properly. This solves the
issues caused by a misconfiguration as described in [1].
The original approach, patching crypto/Kconfig was turned down by
Herbert Xu [2].
[1] https://lists.strongswan.org/pipermail/users/2015-December/009074.html
[2] http://marc.info/?l=linux-crypto-vger&m=145224655809562&w=2
Signed-off-by: Thomas Egerer <hakke_007@gmx.de>
---
net/ipv4/Kconfig | 1 +
net/ipv6/Kconfig | 1 +
2 files changed, 2 insertions(+)
diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index c229205..7758247 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -353,6 +353,7 @@ config INET_ESP
select CRYPTO_CBC
select CRYPTO_SHA1
select CRYPTO_DES
+ select CRYPTO_ECHAINIV
---help---
Support for IPsec ESP.
diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig
index bb7dabe..40c8975 100644
--- a/net/ipv6/Kconfig
+++ b/net/ipv6/Kconfig
@@ -69,6 +69,7 @@ config INET6_ESP
select CRYPTO_CBC
select CRYPTO_SHA1
select CRYPTO_DES
+ select CRYPTO_ECHAINIV
---help---
Support for IPsec ESP.
--
2.6.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ipv4+ipv6: Make INET*_ESP select CRYPTO_ECHAINIV
2016-01-25 11:58 ` Thomas Egerer
@ 2016-01-25 13:56 ` Herbert Xu
2016-01-25 18:46 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Herbert Xu @ 2016-01-25 13:56 UTC (permalink / raw)
To: Thomas Egerer; +Cc: netdev
On Mon, Jan 25, 2016 at 12:58:44PM +0100, Thomas Egerer wrote:
> The ESP algorithms using CBC mode require echainiv. Hence INET*_ESP have
> to select CRYPTO_ECHAINIV in order to work properly. This solves the
> issues caused by a misconfiguration as described in [1].
> The original approach, patching crypto/Kconfig was turned down by
> Herbert Xu [2].
>
> [1] https://lists.strongswan.org/pipermail/users/2015-December/009074.html
> [2] http://marc.info/?l=linux-crypto-vger&m=145224655809562&w=2
>
> Signed-off-by: Thomas Egerer <hakke_007@gmx.de>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ipv4+ipv6: Make INET*_ESP select CRYPTO_ECHAINIV
2016-01-25 13:56 ` Herbert Xu
@ 2016-01-25 18:46 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2016-01-25 18:46 UTC (permalink / raw)
To: herbert; +Cc: hakke_007, netdev
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Mon, 25 Jan 2016 21:56:28 +0800
> On Mon, Jan 25, 2016 at 12:58:44PM +0100, Thomas Egerer wrote:
>> The ESP algorithms using CBC mode require echainiv. Hence INET*_ESP have
>> to select CRYPTO_ECHAINIV in order to work properly. This solves the
>> issues caused by a misconfiguration as described in [1].
>> The original approach, patching crypto/Kconfig was turned down by
>> Herbert Xu [2].
>>
>> [1] https://lists.strongswan.org/pipermail/users/2015-December/009074.html
>> [2] http://marc.info/?l=linux-crypto-vger&m=145224655809562&w=2
>>
>> Signed-off-by: Thomas Egerer <hakke_007@gmx.de>
>
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-25 18:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-23 13:30 [PATCH] ipv4+ipv6: Make INET*_ESP select CRYPTO_ECHAINIV Thomas Egerer
2016-01-25 10:26 ` Herbert Xu
2016-01-25 11:57 ` Thomas Egerer
2016-01-25 11:58 ` Thomas Egerer
2016-01-25 13:56 ` Herbert Xu
2016-01-25 18:46 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).