From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
aaro.koskinen@nokia.com, olof@lixom.net
Subject: Re: [PATCH net 2/2] DT: phy.txt: Clarify expected compatible values
Date: Tue, 26 Jan 2016 17:25:15 -0800 [thread overview]
Message-ID: <56A81C7B.8050201@gmail.com> (raw)
In-Reply-To: <20160127010638.GA4815@lunn.ch>
On 26/01/16 17:06, Andrew Lunn wrote:
> On Tue, Jan 26, 2016 at 04:33:11PM -0800, Florian Fainelli wrote:
>> On 26/01/16 16:11, Andrew Lunn wrote:
>>> PHY devices may only list clause 22, 45, and their PHY identifier
>>> values as compatible values. No other compatible strings are allowed.
>>> Make this clear in the documentation, and remove examples where
>>> make/model compatible strings are listed.
>>
>> Humm, should not we rather require Ethernet PHY Device Tree nodes to
>> have *at least* a "ethernet-phy-ieee802.3-c22" or
>> "ethernet-phy-ieee802.3-c45", and any other compatible string which
>> further specifies the hardware is also welcome?
>
> At the moment, "ethernet-phy-ieee802.3-c45" is used, we look for it
> and act upon it. "ethernet-phy-ieee802.3-c22" is not used anywhere,
> other than my new of_mdiobus_child_is_phy(). Also, for backwards
> compatibility with older blobs, we can never assume one or the other
> will be present.
>
> So you are suggesting we change around 200 ethphy nodes to add in
> "ethernet-phy-ieee802.3-c22", yet we don't actually do anything with
> it?
Well, we do now, since that is one of the results used by
of_mdiobus_child_is_phy(), but you are right, this does not scale.
What I would prefer seeing though is not removing nodes that have at
least two compatible strings, including one that is
"ethernet-phy-ieee802.3-c22", but those which have only one, like the
marvell ones that you patch, should have either an additional
"ethernet-phy-ieee802.3-c22", or none.
Does that make sense?
--
Florian
next prev parent reply other threads:[~2016-01-27 1:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 0:11 [PATCH net 0/2] Part 2 of v4.5-rc1 phylib regression Andrew Lunn
2016-01-27 0:11 ` [PATCH net 1/2] of: of_mdio: Add a whitelist of PHY compatibilities Andrew Lunn
2016-01-27 11:17 ` Aaro Koskinen
2016-01-27 13:51 ` Sergei Shtylyov
2016-01-27 14:03 ` Andrew Lunn
2016-01-27 0:11 ` [PATCH net 2/2] DT: phy.txt: Clarify expected compatible values Andrew Lunn
2016-01-27 0:33 ` Florian Fainelli
2016-01-27 1:06 ` Andrew Lunn
2016-01-27 1:25 ` Florian Fainelli [this message]
2016-01-27 1:57 ` Andrew Lunn
2016-01-27 16:31 ` Florian Fainelli
2016-01-27 16:41 ` Olof Johansson
2016-01-27 17:11 ` Andrew Lunn
2016-01-27 17:32 ` Olof Johansson
2016-01-27 17:36 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A81C7B.8050201@gmail.com \
--to=f.fainelli@gmail.com \
--cc=aaro.koskinen@nokia.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).