* [net] r8169 Remove duplicate command which set RxVlan and RxChksum bits.
@ 2016-01-31 15:33 Corcodel Marian
2016-01-31 17:17 ` Sergei Shtylyov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Corcodel Marian @ 2016-01-31 15:33 UTC (permalink / raw)
To: netdev; +Cc: Corcodel Marian
These bits is already set on set geatures stage.
Signed-off-by: Corcodel Marian <asd@marian1000.go.ro>
---
drivers/net/ethernet/realtek/r8169.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 17d5571..a8fb86d 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -8368,7 +8368,6 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
dev->vlan_features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO |
NETIF_F_HIGHDMA;
- tp->cp_cmd |= RxChkSum | RxVlan;
/*
* Pretend we are using VLANs; This bypasses a nasty bug where
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [net] r8169 Remove duplicate command which set RxVlan and RxChksum bits.
2016-01-31 15:33 [net] r8169 Remove duplicate command which set RxVlan and RxChksum bits Corcodel Marian
@ 2016-01-31 17:17 ` Sergei Shtylyov
2016-01-31 17:17 ` Sergei Shtylyov
2016-02-18 5:25 ` Simon Horman
2 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2016-01-31 17:17 UTC (permalink / raw)
To: Corcodel Marian, netdev
Hello.
On 01/31/2016 06:33 PM, Corcodel Marian wrote:
> These bits is already set on set geatures stage.
Features.
>
> Signed-off-by: Corcodel Marian <asd@marian1000.go.ro>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [net] r8169 Remove duplicate command which set RxVlan and RxChksum bits.
2016-01-31 15:33 [net] r8169 Remove duplicate command which set RxVlan and RxChksum bits Corcodel Marian
2016-01-31 17:17 ` Sergei Shtylyov
@ 2016-01-31 17:17 ` Sergei Shtylyov
2016-02-18 5:25 ` Simon Horman
2 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2016-01-31 17:17 UTC (permalink / raw)
To: Corcodel Marian, netdev
Hello.
On 01/31/2016 06:33 PM, Corcodel Marian wrote:
> These bits is already set on set geatures stage.
Features.
> Signed-off-by: Corcodel Marian <asd@marian1000.go.ro>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [net] r8169 Remove duplicate command which set RxVlan and RxChksum bits.
2016-01-31 15:33 [net] r8169 Remove duplicate command which set RxVlan and RxChksum bits Corcodel Marian
2016-01-31 17:17 ` Sergei Shtylyov
2016-01-31 17:17 ` Sergei Shtylyov
@ 2016-02-18 5:25 ` Simon Horman
2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2016-02-18 5:25 UTC (permalink / raw)
To: Corcodel Marian; +Cc: netdev
On Sun, Jan 31, 2016 at 05:33:08PM +0200, Corcodel Marian wrote:
> These bits is already set on set geatures stage.
>
> Signed-off-by: Corcodel Marian <asd@marian1000.go.ro>
> ---
> drivers/net/ethernet/realtek/r8169.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 17d5571..a8fb86d 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -8368,7 +8368,6 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> dev->vlan_features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO |
> NETIF_F_HIGHDMA;
>
> - tp->cp_cmd |= RxChkSum | RxVlan;
>
To avoid two consecutive blank lines, which seems excessive here,
you may want to consider removing the blank line before or after the
line of code you are removing.
> /*
> * Pretend we are using VLANs; This bypasses a nasty bug where
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-18 5:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-31 15:33 [net] r8169 Remove duplicate command which set RxVlan and RxChksum bits Corcodel Marian
2016-01-31 17:17 ` Sergei Shtylyov
2016-01-31 17:17 ` Sergei Shtylyov
2016-02-18 5:25 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).