From: Hans Westgaard Ry <hans.westgaard.ry@oracle.com>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>,
Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Haakon Bugge <haakon.bugge@oracle.com>
Subject: Re: [PATCH v2] net:Add sysctl_tcp_sg_max_skb_frags
Date: Mon, 1 Feb 2016 14:12:36 +0100 [thread overview]
Message-ID: <56AF59C4.1000807@oracle.com> (raw)
In-Reply-To: <56A9087C.20305@stressinduktion.org>
On 01/27/2016 07:12 PM, Hannes Frederic Sowa wrote:
> On 27.01.2016 16:15, Eric Dumazet wrote:
>>
>> If it is a common one, it should be /proc/sys/net/core/... instead
>> of /proc/sys/net/ipv4/tcp_....
> >
>> Other providers include :
>>
>> 1) GRO stack
>> 2) callers of sock_alloc_send_pskb(), alloc_skb_with_frags(),
>> sock_alloc_send_skb() ..
>
> I agree, this knob should get a generic name and live in a generic
> net/ directory to control this globally, so things don't break during
> forwarding etc.
>
> It does not solve the problem completely, e.g. when VMs send gso
> packets through a vhost-net onto IPoIB, no?
>
> Thanks,
> Hannes
>
I have understood more of the problem Hannes raises and I realize that
we need a slowpath in IPoIB to handle the problem
in question. I will make a new version of this patch with a more correct
position/name of the sysctl-variable.
I'll also make a separate patch adding the slowpath i IPoIB.
Hans
next prev parent reply other threads:[~2016-02-01 13:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 13:16 [PATCH] net: add per device sg_max_frags for skb Hans Westgaard Ry
2016-01-06 13:59 ` David Laight
2016-01-08 9:55 ` Hans Westgaard Ry
2016-01-08 10:33 ` David Laight
2016-01-08 11:47 ` Hannes Frederic Sowa
2016-01-13 13:57 ` Hans Westgaard Ry
2016-01-13 14:19 ` Eric Dumazet
2016-01-13 14:20 ` Eric Dumazet
2016-01-13 15:07 ` Hannes Frederic Sowa
2016-01-13 15:38 ` David Miller
2016-01-13 15:44 ` Eric Dumazet
2016-01-13 21:07 ` Eric W. Biederman
2016-01-27 13:20 ` [PATCH v2] net:Add sysctl_tcp_sg_max_skb_frags Hans Westgaard Ry
2016-01-27 15:15 ` Eric Dumazet
2016-01-27 18:12 ` Hannes Frederic Sowa
2016-02-01 13:12 ` Hans Westgaard Ry [this message]
2016-01-27 20:13 ` David Miller
2016-02-03 8:26 ` [PATCH v3] net:Add sysctl_max_skb_frags Hans Westgaard Ry
2016-02-03 11:25 ` Herbert Xu
2016-02-03 11:36 ` Hannes Frederic Sowa
2016-02-03 12:20 ` Herbert Xu
2016-02-03 14:03 ` Hannes Frederic Sowa
2016-02-03 14:30 ` Eric Dumazet
2016-02-03 17:36 ` David Laight
2016-02-03 15:58 ` Alexander Duyck
2016-02-03 16:07 ` Eric Dumazet
2016-02-03 17:43 ` Alexander Duyck
2016-02-03 17:54 ` Eric Dumazet
2016-02-03 18:24 ` Alexander Duyck
2016-02-03 19:23 ` Eric Dumazet
2016-02-03 21:03 ` Alexander Duyck
2016-02-09 9:30 ` David Miller
2016-01-06 14:05 ` [PATCH] net: add per device sg_max_frags for skb Eric Dumazet
2016-01-08 10:01 ` Hans Westgaard Ry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AF59C4.1000807@oracle.com \
--to=hans.westgaard.ry@oracle.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=haakon.bugge@oracle.com \
--cc=hannes@stressinduktion.org \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).