From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@ericsson.com>,
netdev@vger.kernel.org
Cc: tipc-discussion@lists.sourceforge.net, jon.maloy@ericsson.com,
maloy@donjonn.com, ying.xue@windriver.com
Subject: Re: [PATCH net-next v1 06/10] tipc: fix connection abort when receiving invalid cancel request
Date: Mon, 1 Feb 2016 16:21:58 +0300 [thread overview]
Message-ID: <56AF5BF6.1030108@cogentembedded.com> (raw)
In-Reply-To: <1454319883-16031-7-git-send-email-parthasarathy.bhuvaragan@ericsson.com>
Hello.
On 2/1/2016 12:44 PM, Parthasarathy Bhuvaragan wrote:
> Until now, the subscribers endianness for a subscription
> create/cancel request is determined as:
> swap = !(s->filter & (TIPC_SUB_PORTS | TIPC_SUB_SERVICE))
> The checks are performed only for port/service subscriptions.
>
> The swap calculation is incorrectly if the filter in the subscription
Incorrect.
> cancellation request is set to TIPC_SUB_CANCEL (its a malformed
It's.
> cancel request, as the corresponding subscription create filter
> is missing).
> Thus, the check if the request is for cancellation fails and the
> request is treated as a subscription create request. The
> subscription creation fails as the request is illegal, which
> terminates this connection.
>
> In this commit we determine the endianness by including
> TIPC_SUB_CANCEL, which will set swap correctly and the
> request is processed as a cancel request.
Cancellation, maybe, as it was worded above?
> Acked-by: Ying Xue <ying.xue@windriver.com>
> Reviewed-by: Jon Maloy <jon.maloy@ericsson.com>
> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@ericsson.com>
[...]
MBR, Sergei
next prev parent reply other threads:[~2016-02-01 13:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 9:44 [PATCH net-next v1 00/10] tipc: cleanups, fixes & improvements for topology server Parthasarathy Bhuvaragan
2016-02-01 9:44 ` [PATCH net-next v1 01/10] tipc: remove incorrect check for subscription timeout value Parthasarathy Bhuvaragan
2016-02-01 9:44 ` [PATCH net-next v1 02/10] tipc: remove filter and timeout elements from struct tipc_subscription Parthasarathy Bhuvaragan
2016-02-01 9:44 ` [PATCH net-next v1 03/10] tipc: remove struct tipc_name_seq " Parthasarathy Bhuvaragan
2016-02-01 9:44 ` [PATCH net-next v1 04/10] tipc: introduce tipc_subscrb_subscribe() routine Parthasarathy Bhuvaragan
2016-02-01 9:44 ` [PATCH net-next v1 05/10] tipc: fix connection abort during subscription cancellation Parthasarathy Bhuvaragan
2016-02-01 9:44 ` [PATCH net-next v1 06/10] tipc: fix connection abort when receiving invalid cancel request Parthasarathy Bhuvaragan
2016-02-01 13:21 ` Sergei Shtylyov [this message]
2016-02-01 9:44 ` [PATCH net-next v1 07/10] tipc: hold subscriber->lock for tipc_nametbl_subscribe() Parthasarathy Bhuvaragan
2016-02-01 9:44 ` [PATCH net-next v1 08/10] tipc: protect tipc_subscrb_get() with subscriber spin lock Parthasarathy Bhuvaragan
2016-02-01 9:44 ` [PATCH net-next v1 09/10] tipc: donot create timers if subscription timeout = TIPC_WAIT_FOREVER Parthasarathy Bhuvaragan
2016-02-01 9:44 ` [PATCH net-next v1 10/10] tipc: use alloc_ordered_workqueue() instead of WQ_UNBOUND w/ max_active = 1 Parthasarathy Bhuvaragan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AF5BF6.1030108@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=jon.maloy@ericsson.com \
--cc=maloy@donjonn.com \
--cc=netdev@vger.kernel.org \
--cc=parthasarathy.bhuvaragan@ericsson.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).