From: John Fastabend <john.fastabend@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>, stephen@networkplumber.org
Cc: ast@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 -master 2/4] tc, bpf: improve verifier logging
Date: Mon, 01 Feb 2016 16:51:56 -0800 [thread overview]
Message-ID: <56AFFDAC.3060803@gmail.com> (raw)
In-Reply-To: <24df553c2a0dd547a66e215c89ae75fd6818c750.1454370543.git.daniel@iogearbox.net>
On 16-02-01 04:12 PM, Daniel Borkmann wrote:
> With a bit larger, branchy eBPF programs f.e. already ~BPF_MAXINSNS/7 in
> size, it happens rather quickly that bpf(2) rejects also valid programs
> when only the verifier log buffer size we have in tc is too small.
>
> Change that, so by default we don't do any logging, and only in error
> case we retry with logging enabled. If we should fail providing a
> reasonable dump of the verifier analysis, retry few times with a larger
> log buffer so that we can at least give the user a chance to debug the
> program.
>
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
> ---
> tc/tc_bpf.c | 156 ++++++++++++++++++++++++++++++++++++++++++------------------
Acked-by: John Fastabend <john.r.fastabend@intel.com>
Thanks! I've been hacking around this for a while now but never
got around to fixing it.
next prev parent reply other threads:[~2016-02-02 0:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 0:12 [PATCH iproute2 -master 0/4] Minor BPF updates on frontend Daniel Borkmann
2016-02-02 0:12 ` [PATCH iproute2 -master 1/4] tc, bpf, examples: further bpf_api improvements Daniel Borkmann
2016-02-02 0:12 ` [PATCH iproute2 -master 2/4] tc, bpf: improve verifier logging Daniel Borkmann
2016-02-02 0:51 ` John Fastabend [this message]
2016-02-02 5:02 ` Stephen Hemminger
2016-02-02 0:12 ` [PATCH iproute2 -master 3/4] tc, bpf: give some more hints wrt false relos Daniel Borkmann
2016-02-02 0:12 ` [PATCH iproute2 -master 4/4] tc, bpf: use bind/type macros from gelf Daniel Borkmann
2016-02-02 5:07 ` [PATCH iproute2 -master 0/4] Minor BPF updates on frontend Stephen Hemminger
2016-02-02 9:22 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AFFDAC.3060803@gmail.com \
--to=john.fastabend@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).