From: John Fastabend <john.fastabend@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: anjali.singhai@intel.com, jesse.brandeburg@intel.com,
jhs@mojatatu.com, ast@fb.com, donald.c.skidmore@intel.com,
horms@verge.net.au, netdev@vger.kernel.org, tgraf@suug.ch
Subject: Re: [RFC PATCH 7/7] net: ixgbe: add support for tc_u32 offload
Date: Mon, 01 Feb 2016 20:53:20 -0800 [thread overview]
Message-ID: <56B03640.8050009@gmail.com> (raw)
In-Reply-To: <20160201.181715.1355993690912736292.davem@davemloft.net>
On 16-02-01 06:17 PM, David Miller wrote:
> From: John Fastabend <john.fastabend@gmail.com>
> Date: Sun, 31 Jan 2016 17:53:10 -0800
>
>> + ixgbe_jump_tables[uhtid] = nexthdr->jump;
>
> I can't figure out what protects concurrent accesses to this shared
> ixgbe_jump_table[]. Is RTNL held here? If so it's likely that
> GFP_ATOMIC can be changed to GFP_KERNEL in this function.
>
>
This is only called from tc_ctl_tfilter which is wrapped in the
rtnl_lock as you suspected.
Thanks for the catch I'll convert it to GFP_KERNEL along with the
other spot I copy pasted the GFP_ATOMIC code from.
.John
next prev parent reply other threads:[~2016-02-02 4:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 1:48 [RFC PATCH 0/7] tc cls_u32 hardware interface John Fastabend
2016-02-01 1:49 ` [RFC PATCH 1/7] net: rework ndo tc op to consume additional qdisc handle parameter John Fastabend
2016-02-01 1:49 ` [RFC PATCH 2/7] net: rework setup_tc ndo op to consume general tc operand John Fastabend
2016-02-01 1:50 ` [RFC PATCH 3/7] net: sched: add cls_u32 offload hooks for netdevs John Fastabend
2016-02-02 16:25 ` Or Gerlitz
2016-02-02 16:42 ` John Fastabend
2016-02-02 22:06 ` Or Gerlitz
2016-02-01 1:51 ` [RFC PATCH 4/7] net: add tc offload feature flag John Fastabend
2016-02-01 1:51 ` [RFC PATCH 5/7] net: tc: helper functions to query action types John Fastabend
2016-02-01 1:52 ` [RFC PATCH 6/7] net: ixgbe: add minimal parser details for ixgbe John Fastabend
2016-02-02 16:27 ` Or Gerlitz
2016-02-02 16:46 ` John Fastabend
2016-02-01 1:53 ` [RFC PATCH 7/7] net: ixgbe: add support for tc_u32 offload John Fastabend
2016-02-02 2:17 ` David Miller
2016-02-02 4:53 ` John Fastabend [this message]
2016-02-02 11:49 ` [RFC PATCH 0/7] tc cls_u32 hardware interface Jiri Pirko
2016-02-02 14:58 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B03640.8050009@gmail.com \
--to=john.fastabend@gmail.com \
--cc=anjali.singhai@intel.com \
--cc=ast@fb.com \
--cc=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=horms@verge.net.au \
--cc=jesse.brandeburg@intel.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).